-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ambiguity of glob import with matches!
now in the standard library
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SimonSapin
commented
Oct 25, 2019
``` error[E0659]: `matches` is ambiguous (glob import vs any other name from outer scope during import/macro resolution) --> html5ever/src/tree_builder/tag_sets.rs:109:5 | 109 | matches!( | ^^^^^^^ ambiguous name | = note: `matches` could refer to a macro from prelude note: `matches` could also refer to the macro imported here --> html5ever/src/tree_builder/tag_sets.rs:13:5 | 13 | use mac::*; | ^^^^^^ = help: consider adding an explicit import of `matches` to disambiguate = help: or use `self::matches` to refer to this macro unambiguously error: aborting due to 2 previous errors ```
@bors-servo r+ |
📌 Commit c7691e9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 25, 2019
Fix ambiguity of glob import with `matches!` now in the standard library ```rust error[E0659]: `matches` is ambiguous (glob import vs any other name from outer scope during import/macro resolution) --> html5ever/src/tree_builder/tag_sets.rs:109:5 | 109 | matches!( | ^^^^^^^ ambiguous name | = note: `matches` could refer to a macro from prelude note: `matches` could also refer to the macro imported here --> html5ever/src/tree_builder/tag_sets.rs:13:5 | 13 | use mac::*; | ^^^^^^ = help: consider adding an explicit import of `matches` to disambiguate = help: or use `self::matches` to refer to this macro unambiguously error: aborting due to 2 previous errors ```
☀️ Test successful - checks-travis |
SimonSapin
added a commit
that referenced
this pull request
Oct 25, 2019
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Oct 25, 2019
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 25, 2019
Update html5ever and xml5ever Pick up servo/html5ever#402
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 25, 2019
Update html5ever and xml5ever Pick up servo/html5ever#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.