Update phf to 0.10 #461
Update phf to 0.10 #461
Conversation
|
It would be wonderful if this could be merged and released as it would incidentally resolve rust-lang/rust-playground#780 |
| @@ -15,10 +15,10 @@ path = "lib.rs" | |||
|
|
|||
| [dependencies] | |||
| string_cache = "0.8" | |||
| phf = "0.9" | |||
| phf = "0.10" | |||
There was a problem hiding this comment.
One thing I've done before when the code didn't need to change at all is to have a wide version range:
- phf = "0.9"
+ phf = { version = ">= 0.9, < 0.11" }There was a problem hiding this comment.
This wouldn't really be correct. Because phf has a phf_codegen crate it's possible for Cargo to resolve phf 0.9 and phf_codegen 0.10, which could possibly be bad.
There was a problem hiding this comment.
That would be the responsibility of the phf crate to specify which phf_codegen crate it needs.
If this crate allowed phf {0.8,0.9,0.10} then Cargo could pick any one of those, then would resolve the dependencies for the version it picked.
There was a problem hiding this comment.
phf_codegen is a build-dependency for this crate (see below), and there would be nothing stopping Cargo from picking a different version here. As far Cargo is concerned those crates are unrelated.
|
@bors-servo r+ |
|
📌 Commit 9a35c1b has been approved by |
|
☀️ Test successful - checks-github |
No description provided.