This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Add hyper::Uri support #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Serialize and Deserialize implementations for De<Uri> * Add tests
|
Is there anything blocking this PR from landing? Happy to help with any changes needed. |
nox
suggested changes
Jun 4, 2018
| serde = "1.0" | ||
| serde_bytes = "0.10" | ||
| time = "0.1" | ||
|
|
||
| [dev-dependencies] | ||
| serde_test = "1.0" | ||
| time = "0.1" | ||
|
|
||
| [replace] | ||
| "hyper:0.11.2" = { git = "https://github.com/hyperium/hyper.git" } |
| @@ -412,7 +415,7 @@ impl<'a> Serialize for Ser<'a, Headers> { | |||
| for header in self.v.iter() { | |||
| let name = header.name(); | |||
| let value = self.v.get_raw(name).unwrap(); | |||
| serializer.serialize_entry(name, &Value(value, self.pretty))?; | |||
| serializer.serialize_entry(name, &Value(&value.iter().map(|v| v.to_vec()).collect::<Vec<Vec<u8>>>(), self.pretty))?; | |||
There was a problem hiding this comment.
Why does this need to allocate a new Vec<Vec<u8>>?
| { | ||
| Uri::from_str(v) | ||
| .map(De::new) | ||
| .map_err(|e| E::custom(format!("{:?}", e))) |
| fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error> | ||
| where S: Serializer, | ||
| { | ||
| serializer.serialize_str(&self.v.to_string()) |
| @@ -17,12 +17,15 @@ doctest = false | |||
|
|
|||
| [dependencies] | |||
| cookie = {version = "0.6", default-features = false} | |||
| hyper = "0.10" | |||
| mime = "0.2" | |||
| hyper = { version = "0.11", features = ["raw_status"] } | |||
Closed
|
I opened another PR from my fork integrating the feedback, see #23. |
|
This PR was erased from my memory. Thanks @DarrenTsung for picking it up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #20