Code

[WIP] Add native Windows back-end#166

Code

Closed

antrik wants to merge 109 commits intoservo:masterservo/ipc-channel:masterfrom antrik:windowsantrik/ipc-channel:windowsCopy head branch name to clipboard

+2,410-23

Commits

Commits on May 30, 2018

• tests: cleanup: Avoid .pop().unwrap() in cross_process_sender_transfer()

  Show description for 7c3574b
  

  vvuk

  authored and

  antrik

  committed
  7c3574b

  Copy full SHA for 7c3574b

• tests: Add variants of cross-process test, using spawn()

  Show description for d3aeaa5
  

  vvuk

  authored and

  antrik

  committed
  d3aeaa5

  Copy full SHA for d3aeaa5

• Add inception channel-in-channel multi-process transfer test

  

  vvuk

  authored and

  antrik

  committed
  e38c40c

  Copy full SHA for e38c40c

• tests: Introduce which parameter in get_channel_name_arg() helper

  Show description for 596e456
  antrik

  committed
  596e456

  Copy full SHA for 596e456

• tests: Move get_channel_name_arg() helper to src/test.rs

  Show description for 45f8264
  antrik

  committed
  45f8264

  Copy full SHA for 45f8264

• tests: Introduce cross_process_embedded_senders_spawn()

  Show description for 5afef48
  antrik

  committed
  5afef48

  Copy full SHA for 5afef48

• tests: cleanup: Streamline structure of _server() helpers

  Show description for e3e52a1
  antrik

  committed
  e3e52a1

  Copy full SHA for e3e52a1

• tests: cleanup: Introduce a common spawn_server() helper function

  antrik

  committed
  a2529f8

  Copy full SHA for a2529f8

• tests: cleanup: Avoid need for separate _server() pseudo-tests

  Show description for 58733f6
  antrik

  committed
  58733f6

  Copy full SHA for 58733f6

• Implement ipc-channel on Windows

  Show description for 1a2df12
  

  vvuk

  authored and

  antrik

  committed
  1a2df12

  Copy full SHA for 1a2df12

• appveyor.yml: Restore testing inprocess back-end, not only native one

  antrik

  committed
  5ceb216

  Copy full SHA for 5ceb216

• tests: Split out SHM object equality check

  Show description for 68f6b0c
  antrik

  committed
  68f6b0c

  Copy full SHA for 68f6b0c

• windows: fix warning: reader doesn't need to be mutable

  antrik

  committed
  ca0eea6

  Copy full SHA for ca0eea6

• windows: cleanup: Change suitable plain comments into doc comments

  Show description for 774f9d0
  antrik

  committed
  774f9d0

  Copy full SHA for 774f9d0

• windows: cleanup: Use more standard indentation for macro

  antrik

  committed
  7ee7690

  Copy full SHA for 7ee7690

• windows: Move out original handle in to_receiver() and to_sender()

  Show description for 05fedf6
  antrik

  committed
  05fedf6

  Copy full SHA for 05fedf6

• windows: Drop unnecessary &mut self in a few places

  Show description for 2df82b9
  antrik

  committed
  2df82b9

  Copy full SHA for 2df82b9

• windows: cleanup: Switch methods for a more logical order

  antrik

  committed
  93fd37e

  Copy full SHA for 93fd37e

• windows: Mark notify_completion() as unsafe

  Show description for f9f1eb8
  antrik

  committed
  f9f1eb8

  Copy full SHA for f9f1eb8

• windows: Widen too narrow unsafe block

  Show description for c276d7f
  antrik

  committed
  c276d7f

  Copy full SHA for c276d7f

• windows: Drop custom GetMessageResult type

  Show description for 256e6b6
  antrik

  committed
  256e6b6

  Copy full SHA for 256e6b6

• windows: More defensive receive buffer handling

  Show description for d65a927
  antrik

  committed
  d65a927

  Copy full SHA for d65a927

• [RemoveMe] Temporarily disable most CI targets

  Show description for 524ef10
  antrik

  committed
  524ef10

  Copy full SHA for 524ef10

• windows: Add explanation why the ov structure needs to be boxed

  antrik

  committed
  f3360f4

  Copy full SHA for f3360f4

• windows: Implement Drop for MessageReader

  Show description for 34eb0c3
  antrik

  committed
  34eb0c3

  Copy full SHA for 34eb0c3

• windows: Consume reader immediately when moving out handle

  Show description for c36e495
  antrik

  committed
  c36e495

  Copy full SHA for c36e495

• windows: Take ownership of handle in move_handle_to_process()

  Show description for ad35a32
  antrik

  committed
  ad35a32

  Copy full SHA for ad35a32

• windows: Assert valid state before consuming receiver

  antrik

  committed
  2776819

  Copy full SHA for 2776819

• windows: Don't duplicate handle when consuming receiver

  Show description for 592e43c
  antrik

  committed
  592e43c

  Copy full SHA for 592e43c

• windows: Remove bogus explicit impl Send for OsIpcSender

  Show description for 96f9cc2
  antrik

  committed
  96f9cc2

  Copy full SHA for 96f9cc2

• windows: Add a comment explaining the impl Send on OsIpcReceiver

  antrik

  committed
  6c0cd9c

  Copy full SHA for 6c0cd9c

• windows: cleanup: Use enum rather than anonymous bool for blocking mode parameter

  Show description for ccbd2ee
  antrik

  committed
  ccbd2ee

  Copy full SHA for ccbd2ee

• windows: Improve placement of comments in receive_message()

  antrik

  committed
  7a6f069

  Copy full SHA for 7a6f069

Commits on Jun 8, 2018

• windows: Add checks and warnings regarding dangers of ov and read_buf

  Show description for 3fde2fc
  antrik

  committed
  3fde2fc

  Copy full SHA for 3fde2fc

• windows: Shrink unnecessarily wide unsafe block

  Show description for ec7419a
  antrik

  committed
  ec7419a

  Copy full SHA for ec7419a

• windows: Minor comment fix

  antrik

  committed
  ce80862

  Copy full SHA for ce80862

• windows: cleanup: More straightforward use of default match case

  antrik

  committed
  5bebf06

  Copy full SHA for 5bebf06

• windows: Take WinHandle rather than HANDLE in write_msg() and write_buf()

  Show description for 40a58bb
  antrik

  committed
  40a58bb

  Copy full SHA for 40a58bb

• windows: cleanup: Use helper variable consistently

  antrik

  committed
  76334d3

  Copy full SHA for 76334d3

• windows: cleanup: Merge write_msg() functionality into write_buf()

  Show description for 85f7396
  antrik

  committed
  85f7396

  Copy full SHA for 85f7396

• windows: Shrink an unnecessarily wide unsafe block

  Show description for 9962dc8
  antrik

  committed
  9962dc8

  Copy full SHA for 9962dc8

• windows: Fix overly eager size check

  Show description for f90bc92
  antrik

  committed
  f90bc92

  Copy full SHA for f90bc92

• windows: Fix another overly eager size check

  Show description for a43c96c
  antrik

  committed
  a43c96c

  Copy full SHA for a43c96c

• windows: Revamp send buffer construction to minimise unsafe

  Show description for a51b7c3
  antrik

  committed
  a51b7c3

  Copy full SHA for a51b7c3

• windows: Remove trivial MessageHeader::size() helper

  Show description for d02db85
  antrik

  committed
  d02db85

  Copy full SHA for d02db85

• windows: Turn MessageHeader into normal struct

  Show description for 9c2b758
  antrik

  committed
  9c2b758

  Copy full SHA for 9c2b758

• windows: Check for errors on SHM unmapping

  antrik

  committed
  033cdd8

  Copy full SHA for 033cdd8

• windows: Check for errors on file handle closing

  antrik

  committed
  faee0c3

  Copy full SHA for faee0c3

• windows: Add check to make sure we don't leak OsOpaqueIpcChannel

  Show description for cf2bdac
  antrik

  committed
  cf2bdac

  Copy full SHA for cf2bdac

• windows: Fix SHM mapping for areas larger than 2^32

  Show description for d71a856
  antrik

  committed
  d71a856

  Copy full SHA for d71a856

• windows: Derive PartialEq on WinError

  Show description for 17d87bf
  antrik

  committed
  17d87bf

  Copy full SHA for 17d87bf

• windows: cleanup: Don't intersperse method impls with free-standing function

  Show description for 628a724
  antrik

  committed
  628a724

  Copy full SHA for 628a724

• windows: cleanup: start_read(): Use match for error handling

  antrik

  committed
  f59a916

  Copy full SHA for f59a916

• windows: cleanup: start_read(): Consistenly use explicit return

  Show description for 9bd559b
  antrik

  committed
  9bd559b

  Copy full SHA for 9bd559b

• windows: cleanup: start_read(): Merge handling of identical cases

  Show description for a46741e
  antrik

  committed
  a46741e

  Copy full SHA for a46741e

• windows: cleanup: start_read(): Switch cases for more logical order

  Show description for 9493932
  antrik

  committed
  9493932

  Copy full SHA for 9493932

• windows: cleanup: start_read(): Construct a temporary Result<>

  Show description for 36f16e7
  antrik

  committed
  36f16e7

  Copy full SHA for 36f16e7

• windows: cleanup: Drop redundant comment part

  Show description for 37e67df
  antrik

  committed
  37e67df

  Copy full SHA for 37e67df

• windows: Fix misplaced comment

  Show description for c9b9ad2
  antrik

  committed
  c9b9ad2

  Copy full SHA for c9b9ad2

• windows: Drop bogus Result<> from notify_completion()

  Show description for 897f7a2
  antrik

  committed
  897f7a2

  Copy full SHA for 897f7a2

• windows: Drop bogus comment

  Show description for 421bafd
  antrik

  committed
  421bafd

  Copy full SHA for 421bafd

• windows: Introduce MessageReader.fetch_async_result() helper method

  Show description for 629cb6d
  antrik

  committed
  629cb6d

  Copy full SHA for 629cb6d

• windows: Move Send declaration from OsIpcReceiver to MessageReader

  Show description for dee8c98
  antrik

  committed
  dee8c98

  Copy full SHA for dee8c98

• windows: cleanup: Consume reader in read_raw_sized()

  Show description for d2d0e68
  antrik

  committed
  d2d0e68

  Copy full SHA for d2d0e68

• windows: Avoid code duplication in read_raw_sized()

  Show description for 447be23
  antrik

  committed
  447be23

  Copy full SHA for 447be23

• windows: Take WinHandle rather than HANDLE in add_to_iocp()

  Show description for 6b3064e
  antrik

  committed
  6b3064e

  Copy full SHA for 6b3064e

• windows: Comment on boxing OVERLAPPED inside OsIpcReceiver.accept()

  antrik

  committed
  d378a94

  Copy full SHA for d378a94

• windows: cleanup: OsIpcReceiver.accept(): Unwrap handle at actual use sites

  Show description for 66aded8
  antrik

  committed
  66aded8

  Copy full SHA for 66aded8

• windows: Fix a misleading (outdated?) comment

  antrik

  committed
  e9bca00

  Copy full SHA for e9bca00

• windows: cleanup: Use if let rather than is_some() + unwrap()

  antrik

  committed
  6f29e86

  Copy full SHA for 6f29e86

• windows: cleanup: More idiomatic search code

  antrik

  committed
  0a52f80

  Copy full SHA for 0a52f80

• windows: cleanup: Use if let rather than one-arm match

  Show description for 62a7754
  antrik

  committed
  62a7754

  Copy full SHA for 62a7754

• windows: Don't explicitly set ErrorKind::BrokenPipe on closed sender

  Show description for 86c0891
  antrik

  committed
  86c0891

  Copy full SHA for 86c0891

• windows: cleanup: Use while let rather than loop + match

  Show description for d13aa7c
  antrik

  committed
  d13aa7c

  Copy full SHA for d13aa7c

• windows: refactor: More straightforward "closed" status handling

  Show description for 4fb4e18
  antrik

  committed
  4fb4e18

  Copy full SHA for 4fb4e18

• windows: Don't delay "sender closed" notification from select()

  Show description for 9a56344
  antrik

  committed
  9a56344

  Copy full SHA for 9a56344

• windows: Handle channel closed events directly where possible

  Show description for 5d164cd
  antrik

  committed
  5d164cd

  Copy full SHA for 5d164cd

• windows: cleanup: Simplify control flow

  antrik

  committed
  7d6873d

  Copy full SHA for 7d6873d

• windows: Introduce closed_readers vector instead of MessageReader.closed flag

  Show description for 5ca5a0d
  antrik

  committed
  5ca5a0d

  Copy full SHA for 5ca5a0d

• windows: cleanup: Rename WinHandle.take() to take_raw()

  Show description for 15dd4f2
  antrik

  committed
  15dd4f2

  Copy full SHA for 15dd4f2

• windows: cleanup: More idiomatic for loops

  Show description for eab8460
  antrik

  committed
  eab8460

  Copy full SHA for eab8460

• windows: cleanup: More idiomatic use of tuples

  antrik

  committed
  9925e58

  Copy full SHA for 9925e58

• windows: Use WinHandle in more places

  Show description for 41e3d29
  antrik

  committed
  41e3d29

  Copy full SHA for 41e3d29

• windows: refactor: (Re-)introduce WinHandle.take() with expected meaning

  Show description for 85f1eaa
  antrik

  committed
  85f1eaa

  Copy full SHA for 85f1eaa

• windows: Use explicit as_raw() on WinHandle instead of deref()

  Show description for ddb4515
  antrik

  committed
  ddb4515

  Copy full SHA for ddb4515

• windows: cleanup: Simpler casting for completion_key

  Show description for ec94c03
  antrik

  committed
  ec94c03

  Copy full SHA for ec94c03

• windows: cleanup: Tighten scope of nbytes local variable

  antrik

  committed
  c6c5048

  Copy full SHA for c6c5048

• windows: cleanup: Streamline handling of reader list in select()

  Show description for 27c77ec
  antrik

  committed
  27c77ec

  Copy full SHA for 27c77ec

• windows: Fix unsafe coverage in OsIpcReceiverSet.select()

  Show description for 4a27fe4
  antrik

  committed
  4a27fe4

  Copy full SHA for 4a27fe4

• windows: cleanup: Be more explicit about completion key creation

  antrik

  committed
  a46804d

  Copy full SHA for a46804d

• windows: Rename set_id to entry_id

  Show description for 5732e83
  antrik

  committed
  5732e83

  Copy full SHA for 5732e83

• windows: cleanup: More idiomatic handling of io_err

  Show description for 4b6f122
  antrik

  committed
  4b6f122

  Copy full SHA for 4b6f122

• windows: cleanup: Pass status as a proper Result<>

  Show description for b05b8a6
  antrik

  committed
  b05b8a6

  Copy full SHA for b05b8a6

• windows: cleanup: match on errors in notify_completion()

  Show description for 464f3a9
  antrik

  committed
  464f3a9

  Copy full SHA for 464f3a9

• windows: More defensive read_in_progress handling

  Show description for 7ebae59
  antrik

  committed
  7ebae59

  Copy full SHA for 7ebae59

• windows: Make MessageReader.ov optional

  Show description for 61c21db
  antrik

  committed
  61c21db

  Copy full SHA for 61c21db

• windows: Drop explicit read_in_progress flag

  Show description for 2963ea5
  antrik

  committed
  2963ea5

  Copy full SHA for 2963ea5

• windows: Avoid leaking unsafety outside unsafe blocks

  Show description for 7c1ccfa
  antrik

  committed
  7c1ccfa

  Copy full SHA for 7c1ccfa

• windows: Clarify comment about start_read() for receivers in sets

  antrik

  committed
  95589fa

  Copy full SHA for 95589fa

• windows: Put ov and buf in the same AliasedCell<>

  Show description for 0ecf1cc
  antrik

  committed
  0ecf1cc

  Copy full SHA for 0ecf1cc

• windows: Don't ignore CancelIoEx() errors

  antrik

  committed
  33b15fc

  Copy full SHA for 33b15fc

• windows: Don't panic on unknown errors in notify_completion()

  Show description for 62f30b1
  antrik

  committed
  62f30b1

  Copy full SHA for 62f30b1

• windows: refactor: Split out OsIpcReceiverSet.fetch_iocp_result()

  Show description for ebdfe2b
  antrik

  committed
  ebdfe2b

  Copy full SHA for ebdfe2b

• windows: Make cancel_io() sound

  Show description for f646ea2
  antrik

  committed
  f646ea2

  Copy full SHA for f646ea2

• [RemoveMe] Temporarily restore all CI targets using unix back-end

  Show description for 1e07510
  antrik

  committed
  1e07510

  Copy full SHA for 1e07510

• WIP: threaded fragment tests

  antrik

  committed
  a7d36e1

  Copy full SHA for a7d36e1

• windows: Properly hide all win32-trace code behind conditionals

  Show description for 44f262c
  antrik

  committed
  44f262c

  Copy full SHA for 44f262c

• windows: Introduce MessageReader.get_raw_handle() debug helper

  Show description for 9a67245
  antrik

  committed
  9a67245

  Copy full SHA for 9a67245

• windows: Move handle into AsyncData as well

  Show description for fac85e5
  antrik

  committed
  fac85e5

  Copy full SHA for fac85e5