Code

Windows#233

Code

Closed

angelortiz1007 wants to merge 113 commits intoservo:masterservo/ipc-channel:masterfrom angelortiz1007:windowsCopy head branch name to clipboard

+2,468-26

Commits

Commits on Jun 24, 2019

• tests: cleanup: Avoid .pop().unwrap() in cross_process_sender_transfer()

  Show description for cf2ecd9
  

  vvuk

  authored and

  angelortiz1007

  committed
  cf2ecd9

  Copy full SHA for cf2ecd9

• tests: Add variants of cross-process test, using spawn()

  Show description for 4c6a096
  

  vvuk

  authored and

  angelortiz1007

  committed
  4c6a096

  Copy full SHA for 4c6a096

• Add inception channel-in-channel multi-process transfer test

  

  vvuk

  authored and

  angelortiz1007

  committed
  03687e3

  Copy full SHA for 03687e3

• tests: Introduce which parameter in get_channel_name_arg() helper

  Show description for 1c9f7ab
  

  antrik

  authored and

  angelortiz1007

  committed
  1c9f7ab

  Copy full SHA for 1c9f7ab

• tests: Move get_channel_name_arg() helper to src/test.rs

  Show description for 1f22aa0
  

  antrik

  authored and

  angelortiz1007

  committed
  1f22aa0

  Copy full SHA for 1f22aa0

• tests: Introduce cross_process_embedded_senders_spawn()

  Show description for ad1b9ff
  

  antrik

  authored and

  angelortiz1007

  committed
  ad1b9ff

  Copy full SHA for ad1b9ff

• tests: cleanup: Streamline structure of _server() helpers

  Show description for e4c83d1
  

  antrik

  authored and

  angelortiz1007

  committed
  e4c83d1

  Copy full SHA for e4c83d1

• tests: cleanup: Introduce a common spawn_server() helper function

  

  antrik

  authored and

  angelortiz1007

  committed
  50fe7c4

  Copy full SHA for 50fe7c4

• tests: cleanup: Avoid need for separate _server() pseudo-tests

  Show description for d52be62
  

  antrik

  authored and

  angelortiz1007

  committed
  d52be62

  Copy full SHA for d52be62

• Implement ipc-channel on Windows

  Show description for 3347fc1
  

  vvuk

  authored and

  angelortiz1007

  committed
  3347fc1

  Copy full SHA for 3347fc1

• appveyor.yml: Restore testing inprocess back-end, not only native one

  

  antrik

  authored and

  angelortiz1007

  committed
  57bc52e

  Copy full SHA for 57bc52e

• tests: Split out SHM object equality check

  Show description for 3eb82d9
  

  antrik

  authored and

  angelortiz1007

  committed
  3eb82d9

  Copy full SHA for 3eb82d9

• windows: fix warning: reader doesn't need to be mutable

  

  antrik

  authored and

  angelortiz1007

  committed
  ab99734

  Copy full SHA for ab99734

• windows: cleanup: Change suitable plain comments into doc comments

  Show description for 75763d0
  

  antrik

  authored and

  angelortiz1007

  committed
  75763d0

  Copy full SHA for 75763d0

• windows: cleanup: Use more standard indentation for macro

  

  antrik

  authored and

  angelortiz1007

  committed
  0e48d3f

  Copy full SHA for 0e48d3f

• windows: Move out original handle in to_receiver() and to_sender()

  Show description for 19af7c9
  

  antrik

  authored and

  angelortiz1007

  committed
  19af7c9

  Copy full SHA for 19af7c9

• windows: Drop unnecessary &mut self in a few places

  Show description for db07779
  

  antrik

  authored and

  angelortiz1007

  committed
  db07779

  Copy full SHA for db07779

• windows: cleanup: Switch methods for a more logical order

  

  antrik

  authored and

  angelortiz1007

  committed
  80ee2d7

  Copy full SHA for 80ee2d7

• windows: Mark notify_completion() as unsafe

  Show description for 505a3df
  

  antrik

  authored and

  angelortiz1007

  committed
  505a3df

  Copy full SHA for 505a3df

• windows: Widen too narrow unsafe block

  Show description for 27376c3
  

  antrik

  authored and

  angelortiz1007

  committed
  27376c3

  Copy full SHA for 27376c3

• windows: Drop custom GetMessageResult type

  Show description for 4cc8401
  

  antrik

  authored and

  angelortiz1007

  committed
  4cc8401

  Copy full SHA for 4cc8401

• windows: More defensive receive buffer handling

  Show description for 712c37a
  

  antrik

  authored and

  angelortiz1007

  committed
  712c37a

  Copy full SHA for 712c37a

• [RemoveMe] Temporarily disable most CI targets

  Show description for 1c33a04
  

  antrik

  authored and

  angelortiz1007

  committed
  1c33a04

  Copy full SHA for 1c33a04

• windows: Add explanation why the ov structure needs to be boxed

  

  antrik

  authored and

  angelortiz1007

  committed
  6642fbe

  Copy full SHA for 6642fbe

• windows: Implement Drop for MessageReader

  Show description for 82fc077
  

  antrik

  authored and

  angelortiz1007

  committed
  82fc077

  Copy full SHA for 82fc077

• windows: Consume reader immediately when moving out handle

  Show description for 8a546b8
  

  antrik

  authored and

  angelortiz1007

  committed
  8a546b8

  Copy full SHA for 8a546b8

• windows: Take ownership of handle in move_handle_to_process()

  Show description for 5f70a30
  

  antrik

  authored and

  angelortiz1007

  committed
  5f70a30

  Copy full SHA for 5f70a30

• windows: Assert valid state before consuming receiver

  

  antrik

  authored and

  angelortiz1007

  committed
  5649048

  Copy full SHA for 5649048

• windows: Don't duplicate handle when consuming receiver

  Show description for 80a2898
  

  antrik

  authored and

  angelortiz1007

  committed
  80a2898

  Copy full SHA for 80a2898

• windows: Remove bogus explicit impl Send for OsIpcSender

  Show description for 5934d72
  

  antrik

  authored and

  angelortiz1007

  committed
  5934d72

  Copy full SHA for 5934d72

• windows: Add a comment explaining the impl Send on OsIpcReceiver

  

  antrik

  authored and

  angelortiz1007

  committed
  b14fa51

  Copy full SHA for b14fa51

• windows: cleanup: Use enum rather than anonymous bool for blocking mode parameter

  Show description for c0f3fd8
  

  antrik

  authored and

  angelortiz1007

  committed
  c0f3fd8

  Copy full SHA for c0f3fd8

• windows: Improve placement of comments in receive_message()

  

  antrik

  authored and

  angelortiz1007

  committed
  e27cfaf

  Copy full SHA for e27cfaf

• windows: Add checks and warnings regarding dangers of ov and read_buf

  Show description for 65699b1
  

  antrik

  authored and

  angelortiz1007

  committed
  65699b1

  Copy full SHA for 65699b1

• windows: Shrink unnecessarily wide unsafe block

  Show description for dfcae21
  

  antrik

  authored and

  angelortiz1007

  committed
  dfcae21

  Copy full SHA for dfcae21

• windows: Minor comment fix

  

  antrik

  authored and

  angelortiz1007

  committed
  7a600b7

  Copy full SHA for 7a600b7

• windows: cleanup: More straightforward use of default match case

  

  antrik

  authored and

  angelortiz1007

  committed
  56c0f30

  Copy full SHA for 56c0f30

• windows: Take WinHandle rather than HANDLE in write_msg() and write_buf()

  Show description for 2265c29
  

  antrik

  authored and

  angelortiz1007

  committed
  2265c29

  Copy full SHA for 2265c29

• windows: cleanup: Use helper variable consistently

  

  antrik

  authored and

  angelortiz1007

  committed
  216d1ce

  Copy full SHA for 216d1ce

• windows: cleanup: Merge write_msg() functionality into write_buf()

  Show description for 91e95bf
  

  antrik

  authored and

  angelortiz1007

  committed
  91e95bf

  Copy full SHA for 91e95bf

• windows: Shrink an unnecessarily wide unsafe block

  Show description for 3c921a7
  

  antrik

  authored and

  angelortiz1007

  committed
  3c921a7

  Copy full SHA for 3c921a7

• windows: Fix overly eager size check

  Show description for ec03bd1
  

  antrik

  authored and

  angelortiz1007

  committed
  ec03bd1

  Copy full SHA for ec03bd1

• windows: Fix another overly eager size check

  Show description for b50dc8b
  

  antrik

  authored and

  angelortiz1007

  committed
  b50dc8b

  Copy full SHA for b50dc8b

• windows: Revamp send buffer construction to minimise unsafe

  Show description for 42e8304
  

  antrik

  authored and

  angelortiz1007

  committed
  42e8304

  Copy full SHA for 42e8304

• windows: Remove trivial MessageHeader::size() helper

  Show description for d70b8c9
  

  antrik

  authored and

  angelortiz1007

  committed
  d70b8c9

  Copy full SHA for d70b8c9

• windows: Turn MessageHeader into normal struct

  Show description for f742ceb
  

  antrik

  authored and

  angelortiz1007

  committed
  f742ceb

  Copy full SHA for f742ceb

• windows: Check for errors on SHM unmapping

  

  antrik

  authored and

  angelortiz1007

  committed
  9e28ebe

  Copy full SHA for 9e28ebe

• windows: Check for errors on file handle closing

  

  antrik

  authored and

  angelortiz1007

  committed
  4656176

  Copy full SHA for 4656176

• windows: Add check to make sure we don't leak OsOpaqueIpcChannel

  Show description for 776dd31
  

  antrik

  authored and

  angelortiz1007

  committed
  776dd31

  Copy full SHA for 776dd31

• windows: Fix SHM mapping for areas larger than 2^32

  Show description for f4987b5
  

  antrik

  authored and

  angelortiz1007

  committed
  f4987b5

  Copy full SHA for f4987b5

• windows: Derive PartialEq on WinError

  Show description for ad4e40d
  

  antrik

  authored and

  angelortiz1007

  committed
  ad4e40d

  Copy full SHA for ad4e40d

• windows: cleanup: Don't intersperse method impls with free-standing function

  Show description for f801fbe
  

  antrik

  authored and

  angelortiz1007

  committed
  f801fbe

  Copy full SHA for f801fbe

• windows: cleanup: start_read(): Use match for error handling

  

  antrik

  authored and

  angelortiz1007

  committed
  9b288b7

  Copy full SHA for 9b288b7

• windows: cleanup: start_read(): Consistenly use explicit return

  Show description for 15e8346
  

  antrik

  authored and

  angelortiz1007

  committed
  15e8346

  Copy full SHA for 15e8346

• windows: cleanup: start_read(): Merge handling of identical cases

  Show description for 888773d
  

  antrik

  authored and

  angelortiz1007

  committed
  888773d

  Copy full SHA for 888773d

• windows: cleanup: start_read(): Switch cases for more logical order

  Show description for 6e406d8
  

  antrik

  authored and

  angelortiz1007

  committed
  6e406d8

  Copy full SHA for 6e406d8

• windows: cleanup: start_read(): Construct a temporary Result<>

  Show description for f3a0c1d
  

  antrik

  authored and

  angelortiz1007

  committed
  f3a0c1d

  Copy full SHA for f3a0c1d

• windows: cleanup: Drop redundant comment part

  Show description for 608a0f5
  

  antrik

  authored and

  angelortiz1007

  committed
  608a0f5

  Copy full SHA for 608a0f5

• windows: Fix misplaced comment

  Show description for 8163de2
  

  antrik

  authored and

  angelortiz1007

  committed
  8163de2

  Copy full SHA for 8163de2

• windows: Drop bogus Result<> from notify_completion()

  Show description for fa9ecb2
  

  antrik

  authored and

  angelortiz1007

  committed
  fa9ecb2

  Copy full SHA for fa9ecb2

• windows: Drop bogus comment

  Show description for b41423c
  

  antrik

  authored and

  angelortiz1007

  committed
  b41423c

  Copy full SHA for b41423c

• windows: Introduce MessageReader.fetch_async_result() helper method

  Show description for 1eb97b8
  

  antrik

  authored and

  angelortiz1007

  committed
  1eb97b8

  Copy full SHA for 1eb97b8

• windows: Move Send declaration from OsIpcReceiver to MessageReader

  Show description for db945e4
  

  antrik

  authored and

  angelortiz1007

  committed
  db945e4

  Copy full SHA for db945e4

• windows: cleanup: Consume reader in read_raw_sized()

  Show description for 41e5b9c
  

  antrik

  authored and

  angelortiz1007

  committed
  41e5b9c

  Copy full SHA for 41e5b9c

• windows: Avoid code duplication in read_raw_sized()

  Show description for 3de41e9
  

  antrik

  authored and

  angelortiz1007

  committed
  3de41e9

  Copy full SHA for 3de41e9

• windows: Take WinHandle rather than HANDLE in add_to_iocp()

  Show description for bcf026f
  

  antrik

  authored and

  angelortiz1007

  committed
  bcf026f

  Copy full SHA for bcf026f

• windows: Comment on boxing OVERLAPPED inside OsIpcReceiver.accept()

  

  antrik

  authored and

  angelortiz1007

  committed
  21c92ab

  Copy full SHA for 21c92ab

• windows: cleanup: OsIpcReceiver.accept(): Unwrap handle at actual use sites

  Show description for 3cc52e8
  

  antrik

  authored and

  angelortiz1007

  committed
  3cc52e8

  Copy full SHA for 3cc52e8

• windows: Fix a misleading (outdated?) comment

  

  antrik

  authored and

  angelortiz1007

  committed
  3fa1de2

  Copy full SHA for 3fa1de2

• windows: cleanup: Use if let rather than is_some() + unwrap()

  

  antrik

  authored and

  angelortiz1007

  committed
  cc31739

  Copy full SHA for cc31739

• windows: cleanup: More idiomatic search code

  

  antrik

  authored and

  angelortiz1007

  committed
  f6c276c

  Copy full SHA for f6c276c

• windows: cleanup: Use if let rather than one-arm match

  Show description for 1dc0270
  

  antrik

  authored and

  angelortiz1007

  committed
  1dc0270

  Copy full SHA for 1dc0270

• windows: Don't explicitly set ErrorKind::BrokenPipe on closed sender

  Show description for cfeab5f
  

  antrik

  authored and

  angelortiz1007

  committed
  cfeab5f

  Copy full SHA for cfeab5f

• windows: cleanup: Use while let rather than loop + match

  Show description for 686960f
  

  antrik

  authored and

  angelortiz1007

  committed
  686960f

  Copy full SHA for 686960f

• windows: refactor: More straightforward "closed" status handling

  Show description for b1d2b97
  

  antrik

  authored and

  angelortiz1007

  committed
  b1d2b97

  Copy full SHA for b1d2b97

• windows: Don't delay "sender closed" notification from select()

  Show description for fbd8632
  

  antrik

  authored and

  angelortiz1007

  committed
  fbd8632

  Copy full SHA for fbd8632

• windows: Handle channel closed events directly where possible

  Show description for 6687016
  

  antrik

  authored and

  angelortiz1007

  committed
  6687016

  Copy full SHA for 6687016

• windows: cleanup: Simplify control flow

  

  antrik

  authored and

  angelortiz1007

  committed
  91b4331

  Copy full SHA for 91b4331

• windows: Introduce closed_readers vector instead of MessageReader.closed flag

  Show description for 17c7901
  

  antrik

  authored and

  angelortiz1007

  committed
  17c7901

  Copy full SHA for 17c7901

• windows: cleanup: Rename WinHandle.take() to take_raw()

  Show description for 4f0d5e2
  

  antrik

  authored and

  angelortiz1007

  committed
  4f0d5e2

  Copy full SHA for 4f0d5e2

• windows: cleanup: More idiomatic for loops

  Show description for fb768aa
  

  antrik

  authored and

  angelortiz1007

  committed
  fb768aa

  Copy full SHA for fb768aa

• windows: cleanup: More idiomatic use of tuples

  

  antrik

  authored and

  angelortiz1007

  committed
  5374198

  Copy full SHA for 5374198

• windows: Use WinHandle in more places

  Show description for 4d1dd1d
  

  antrik

  authored and

  angelortiz1007

  committed
  4d1dd1d

  Copy full SHA for 4d1dd1d

• windows: refactor: (Re-)introduce WinHandle.take() with expected meaning

  Show description for 7119bee
  

  antrik

  authored and

  angelortiz1007

  committed
  7119bee

  Copy full SHA for 7119bee

• windows: Use explicit as_raw() on WinHandle instead of deref()

  Show description for 143cce1
  

  antrik

  authored and

  angelortiz1007

  committed
  143cce1

  Copy full SHA for 143cce1

• windows: cleanup: Simpler casting for completion_key

  Show description for 8b9db47
  

  antrik

  authored and

  angelortiz1007

  committed
  8b9db47

  Copy full SHA for 8b9db47

• windows: cleanup: Tighten scope of nbytes local variable

  

  antrik

  authored and

  angelortiz1007

  committed
  da172ac

  Copy full SHA for da172ac

• windows: cleanup: Streamline handling of reader list in select()

  Show description for 3627454
  

  antrik

  authored and

  angelortiz1007

  committed
  3627454

  Copy full SHA for 3627454

• windows: Fix unsafe coverage in OsIpcReceiverSet.select()

  Show description for d070683
  

  antrik

  authored and

  angelortiz1007

  committed
  d070683

  Copy full SHA for d070683

• windows: cleanup: Be more explicit about completion key creation

  

  antrik

  authored and

  angelortiz1007

  committed
  f36ffa4

  Copy full SHA for f36ffa4

• windows: Rename set_id to entry_id

  Show description for e90a90f
  

  antrik

  authored and

  angelortiz1007

  committed
  e90a90f

  Copy full SHA for e90a90f

• windows: cleanup: More idiomatic handling of io_err

  Show description for 55afd64
  

  antrik

  authored and

  angelortiz1007

  committed
  55afd64

  Copy full SHA for 55afd64

• windows: cleanup: Pass status as a proper Result<>

  Show description for 5062c26
  

  antrik

  authored and

  angelortiz1007

  committed
  5062c26

  Copy full SHA for 5062c26

• windows: cleanup: match on errors in notify_completion()

  Show description for 6831ca2
  

  antrik

  authored and

  angelortiz1007

  committed
  6831ca2

  Copy full SHA for 6831ca2

• windows: More defensive read_in_progress handling

  Show description for 2b6c93e
  

  antrik

  authored and

  angelortiz1007

  committed
  2b6c93e

  Copy full SHA for 2b6c93e

• windows: Make MessageReader.ov optional

  Show description for 48a33db
  

  antrik

  authored and

  angelortiz1007

  committed
  48a33db

  Copy full SHA for 48a33db

• windows: Drop explicit read_in_progress flag

  Show description for b9c3004
  

  antrik

  authored and

  angelortiz1007

  committed
  b9c3004

  Copy full SHA for b9c3004

• windows: Avoid leaking unsafety outside unsafe blocks

  Show description for 05fd68d
  

  antrik

  authored and

  angelortiz1007

  committed
  05fd68d

  Copy full SHA for 05fd68d

• windows: Clarify comment about start_read() for receivers in sets

  

  antrik

  authored and

  angelortiz1007

  committed
  b1eb0c9

  Copy full SHA for b1eb0c9

• windows: Put ov and buf in the same AliasedCell<>

  Show description for eccd9d4
  

  antrik

  authored and

  angelortiz1007

  committed
  eccd9d4

  Copy full SHA for eccd9d4

• windows: Don't ignore CancelIoEx() errors

  

  antrik

  authored and

  angelortiz1007

  committed
  86ea0f1

  Copy full SHA for 86ea0f1

• windows: Don't panic on unknown errors in notify_completion()

  Show description for 66aa634
  

  antrik

  authored and

  angelortiz1007

  committed
  66aa634

  Copy full SHA for 66aa634

• windows: refactor: Split out OsIpcReceiverSet.fetch_iocp_result()

  Show description for 54e3faf
  

  antrik

  authored and

  angelortiz1007

  committed
  54e3faf

  Copy full SHA for 54e3faf

• windows: Make cancel_io() sound

  Show description for b85e676
  

  antrik

  authored and

  angelortiz1007

  committed
  b85e676

  Copy full SHA for b85e676

• [RemoveMe] Temporarily restore all CI targets using unix back-end

  Show description for 0758099
  

  antrik

  authored and

  angelortiz1007

  committed
  0758099

  Copy full SHA for 0758099

• WIP: threaded fragment tests

  

  antrik

  authored and

  angelortiz1007

  committed
  3481ef1

  Copy full SHA for 3481ef1

• windows: Properly hide all win32-trace code behind conditionals

  Show description for 12e03b9
  

  antrik

  authored and

  angelortiz1007

  committed
  12e03b9

  Copy full SHA for 12e03b9

• windows: Introduce MessageReader.get_raw_handle() debug helper

  Show description for 0aefbb9
  

  antrik

  authored and

  angelortiz1007

  committed
  0aefbb9

  Copy full SHA for 0aefbb9

• windows: Move handle into AsyncData as well

  Show description for 1a023e9
  

  antrik

  authored and

  angelortiz1007

  committed
  1a023e9

  Copy full SHA for 1a023e9

• fixup! Implement ipc-channel on Windows

  angelortiz1007

  committed
  6e678a7

  Copy full SHA for 6e678a7

• Update for Rust 2018.

  angelortiz1007

  committed
  6a51744

  Copy full SHA for 6a51744

Commits on Jun 26, 2019

• Migrated ipc-channel to use winapi version 3. Removed kernel3

  angelortiz1007

  committed
  237e026

  Copy full SHA for 237e026

Commits on Jul 3, 2019

• Test of GetNamedPipeClientSessionId() and GetNamedPipeClientSessionId() apis to verify if self.h and other.h handles point to the same object.

  angelortiz1007

  committed
  24a2207

  Copy full SHA for 24a2207