Fix a leak in IpcOneShotServer on MacOS #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Sep 5, 2023
src/platform/macos/mod.rs
Outdated
| @@ -832,22 +824,26 @@ fn select( | |||
| pub struct OsIpcOneShotServer { | |||
| receiver: OsIpcReceiver, | |||
| name: String, | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
This field looks like it's read in the destructor. Why is this necessary?
There was a problem hiding this comment.
Hrm. I think I was just confused at the moment that I added this. It isn't necessary. I've pushed a new version of this change that removes it.
The code allocates a mach port and it needs to deallocate it when the server is dropped. Fixes #262.
mrobinson
force-pushed
the
fix-oneshot-leak
branch
from
1cd06ec to
f56082e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code allocates a mach port and it needs to deallocate it when the
server is dropped.
Fixes #262.