update recv to use correct values on FreeBSD #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you either change only the parts that are affected, like |
|
Updated my commit to be more "surgical." Thanks for the suggestions. |
jdm
reviewed
Jul 29, 2024
180watt
force-pushed
the
main
branch
2 times, most recently
from
0a84f22 to
8535ae0
Compare
wusyong
approved these changes
Jul 29, 2024
jdm
reviewed
Jul 29, 2024
src/platform/unix/mod.rs
Outdated
| #[cfg(target_os = "freebsd")] | ||
| let result = libc::poll( | ||
| fd.as_mut_ptr(), | ||
| fd.len() as libc::c_uint, |
There was a problem hiding this comment.
We should be able to use as _ and avoid any platform-specific code.
Use correct value for POLLRDHUP and make fd.len cast more portable. Signed-off-by: 180watt <180watt@duck.com>
|
I have missed a critical |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's rather unfortunate that Rust's libc doesn't know that FreeBSD has POLLRDHUP, but in the mean time we can add the value ourselves. We also need to use a uint for
nfds_t. It seems that illumos also has POLLRDHUP, so this implementation could work there too. (Testing welcome.) I'm a novice when it comes to Rust, so any suggestions to this patch is very welcomed.P.S. I failed to mention this, but in its current state (pre-patch), ipc-channel fails to build on FreeBSD