in recvmsg, pass in MSG_CMSG_CLOEXEC on illumos #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for MSG_CMSG_CLOEXEC was added to illumos in a [recent commit]. To match the behavior on Linux, pass in the flag on illumos (the definition was added in libc 0.2.162). I've verified that the ipc-channel test suite still passes on an older illumos kernel which doesn't have support for it. This is okay because for returned fds, cloexec support is effectively best-effort. [recent commit]: illumos/illumos-gate@0250c53
jdm
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for MSG_CMSG_CLOEXEC was added to illumos in a recent commit. To match the behavior on Linux, pass in the flag on illumos (the definition was added in libc 0.2.162).
I've verified that the ipc-channel test suite still passes on an older illumos kernel which doesn't have support for it. This is okay because for returned fds, cloexec support is effectively best-effort.