Deprecate old shared memory fd creation #374
Conversation
| @@ -26,7 +26,6 @@ harness = false | |||
| [features] | |||
| default = [] | |||
| force-inprocess = [] | |||
| memfd = [] | |||
There was a problem hiding this comment.
Let's leave the feature with a comment saying it's deprecated. This will allow us to put off having to make a semver-major version change.
There was a problem hiding this comment.
Sort of makes sense, but because its major is <1, semver allows to do anything.
It could be minor or patch version dump too.
However, (I just realize) memfd feature is used in the GHA workflow atm, and that also needs some care.
I'd vote for removing memfd feature completely therefore decreasing unnecessary complexity.
what do you think?
There was a problem hiding this comment.
I think we need to bump anyway, given that this internal change removes support for some old systems.
There was a problem hiding this comment.
That position is reasonable. I'll merge this as-is.
|
BTW for shm_open in gaol, firefox has this in their sandbox code: https://searchfox.org/mozilla-central/source/security/sandbox/linux/Sandbox.cpp#572 |
I tried it out, but same issue. Tbh I cannot fathom what causes it, but it's also not my field of expertise. (evidently not the syscall itself, as audit doesn't report violation. It has to be something in the environment.) But as it is major incompatibility, I see no reason to support it. (unless somebody can fix it, then I'm up for it, sure) |
| @@ -26,7 +26,6 @@ harness = false | |||
| [features] | |||
| default = [] | |||
| force-inprocess = [] | |||
| memfd = [] | |||
There was a problem hiding this comment.
That position is reasonable. I'll merge this as-is.
During the attempt to fix
gaol <> ipc-channelincompatibilities, I was trying to fix the errors first. thememfd_createis fixable on gaol side, but I was not able to fix theshm_open.I cannot really point out the issue. I suspect some tricky bitflip playing around the usernamespace and permissions, but I have no evidence tbh.
Anyhow,
memfd_createis part of the linux kernel from 2014, and also part of FreeBSD from 2021.I don't see strong reason to keep the older
shm_openmethod.according to GNU libc manual:
shm_open: MT-Safe locale | AS-Unsafe init heap lock | AC-Unsafe lock mem fdmemfd_create: MT-Safe | AS-Safe | AC-Safe fd