Use url.port instead of hardcoding port 80 #15
Conversation
|
Looks good aside from the note above. |
| @@ -120,8 +121,12 @@ impl<C: Connection, CF: ConnectionFactory<C>> HttpRequest<C, CF> { | |||
| debug!("http_client: using IP %? for %?", format_addr(&ip_addr), self.url.to_str()); | |||
|
|
|||
| let socket = { | |||
| debug!("http_client: connecting to %?", ip_addr); | |||
| let socket = self.connection_factory.connect(copy ip_addr, 80); | |||
| let port = match self.url.port.clone() { | |||
There was a problem hiding this comment.
With
let port = match self.url.port {
Some(port) => uint::from_str(port).get(),
_ => 80
};
I was getting
$ make
cc -fPIC http_parser.c -o http_parser.o -c
ar rcs libhttp_parser.a http_parser.o
rustc http_client.rc -o libhttp_client.dummy
http_client.rc:125:16: 125:26 error: cannot move out of dereference of & pointer
http_client.rc:125 Some(port) => uint::from_str(port).get(),
^~~~~~~~~~
error: aborting due to previous error
make: *** [libhttp_client.dummy] Error 101
^~~~
How do I do that? Thanks for your help.
There was a problem hiding this comment.
The code sample and line from the error don't match. The first one looks like it should Just Work.
There was a problem hiding this comment.
Copy and paste error. I've updated the error message I'm getting. This is with Rust 0.8-pre from a few days back.
There was a problem hiding this comment.
I grabbed the latest rust and it breaks all sorts of things :) Seems like copy is gone and extra::net::ip moved. I'll switch to rust 0.7 and test.
Is the general policy of servo to track the last release, or how does that work?
There was a problem hiding this comment.
Using release-0.7 tag of rust (rustc 0.7 (a2db7c1 2013-07-02 09:25:44 -0700)... this module doesn't build unless I update parser.rs
+use std::vec;
- do data.as_imm_buf |buf, _| {
+ do vec::as_imm_buf(data) |buf, _| {
Then I can build. I still get this error:
http_client.rc:125:16: 125:26 error: cannot move out of dereference of & pointer
http_client.rc:125 Some(port) => uint::from_str(port).get(),
^~~~~~~~~~
There was a problem hiding this comment.
The general policy for Servo rustc versions is we don't upgrade until we need to, so you can replicate the version we're using from the submodule at https://github.com/mozilla/servo/tree/master/src/compiler.
There was a problem hiding this comment.
This is very helpful! I'll do configure --prefix=~/local/servo-rust and keep that installation around for testing rust-http-client.
Thanks!
|
I got a little lost on next steps. Happy to tweak this pull request. |
In my Rust project, I want to connect to port 8002. Patch uses
url.portinstead of hardcoded port 80.Aside: I've got a simple Node.js http-proxy on 8002 to proxy http to https traffic, since we don't have a rust-https-client yet. But, I can't use it without this port tweak.