Skip to content
This repository was archived by the owner on Nov 12, 2022. It is now read-only.

Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07) #358

Merged
merged 1 commit into from
May 7, 2017
Merged

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented May 7, 2017

This change is Reviewable

@nox
Copy link
Contributor

nox commented May 7, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 61dc5c9 has been approved by nox

@bors-servo
Copy link
Contributor

⌛ Testing commit 61dc5c9 with merge a88d705...

bors-servo pushed a commit that referenced this pull request May 7, 2017
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/358)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member Author

Travis fails because rust-lang/rust#41064 hasn’t reached Nigthly yet. Tested locally with rustc 1.19.0-nightly (ced823e26 2017-05-07).

cargo test --features debugmozjs shows:

WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!

… but it already did in https://travis-ci.org/servo/rust-mozjs/jobs/225720367.

@bors-servo
Copy link
Contributor

💔 Test failed - status-travis

@SimonSapin SimonSapin merged commit 08af365 into master May 7, 2017
@SimonSapin SimonSapin deleted the rustup branch May 7, 2017 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants