-
Notifications
You must be signed in to change notification settings - Fork 24
Remove string cache and some traits #100
Remove string cache and some traits #100
Conversation
4034d93
to
98f0a16
Compare
r? @nox |
98f0a16
to
7346186
Compare
At first I split the bloom filter into its own crate so that implementing My guess is that hashing will be slightly more expensive than before, but we might get fewer hash collisions. (The previous This PR also weakens a test that check the number of false positives in a bloom filter. I believe this test only passed before because it hashes consecutive integers, which the previous |
@bors-servo r+ |
📌 Commit 7346186 has been approved by |
…lit-bloom, r=nox Remove string cache and some traits <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/100) <!-- Reviewable:end -->
☀️ Test successful - status-travis |
This change is