Bring SmallVec closer to Vec #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a forced refactoring of the current `into_iter` method which was renamed to `drain` as it would otherwise conflict with `impl<A: Array> IntoIter for SmallVec<A> { ... }`
|
The renaming of |
|
Might be worth adding tests for borrow/as_ref and anything else I missed? |
|
Added tests for traits that missed them! |
|
Bump |
| type Item = A::Item; | ||
|
|
||
| #[inline] | ||
| #[inline] |
|
Looks good to me; I'd appreciate if this could land soon :) |
|
Looks good, thanks! @bors-servo r+ |
|
📌 Commit 200f4f2 has been approved by |
|
http://build.servo.org/homu/queue/rust-smallvec shows this PR as approved, but it doesn’t look like a Travis build is being scheduled. CC @larsbergstrom https://travis-ci.org/servo/rust-smallvec/builds/151422387 is green. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements almost all traits which Vec implements for
SmallVec, bringing it closer to being a drop in replacement forVec. A few implementations were omitted such asExtend<&A::Item>which could not be implemented due to a conflict withExtend<A::Item>, a fewFromimplementations which may be a bit more esoteric (easily added if so desired) andWrite.This change is