-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDNA support #119
IDNA support #119
Conversation
# except according to those terms. | ||
|
||
|
||
# Run as: python make_idna_table.py idna_table.txt > src/idna_table.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is idna_table.txt
provided by Unicode? Where can it be found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this URL in a code comment.
Could you also integrate the tests form http://www.unicode.org/Public/idna/latest/IdnaTest.txt ? I’m considering rewriting the Python scripts to Rust and running them as Cargo build scripts to avoid having generated files in the repository. However in Gecko it’s not as easy if you’re not using Cargo. It would be a separate How painful is it to do in Gecko? If it would make your like more difficult I can stick to Python and generated files in the repository. |
It would be a bit harder to have the Gecko build system run the rust files at build time, but at the moment that's not a blocker. We can include the the generated rust-generated files just as we do with the python generated ones at the moment. |
☔ The latest upstream changes (presumably #125) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #129) made this pull request unmergeable. Please resolve the merge conflicts. |
… and fix values for URLs where true/false were swapped.
See #152 |
I've implemented the BIDI checks, and now all of the tests pass (except the contextJ tests, which client software isn't required to pass). |
Other than a few nits I think this is ready to land. Thanks again! |
@bors-servo r+ |
Not sure what’s happening with homu, but the Travis build for the PR push is green. |
I wrote a UTS 46 implementation based on http://intertwingly.net/projects/pegurl/idna.js
It needs a fast path for ascii codepoints, but I wanted to get some feedback on it first.