Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum rust-version to 1.51 to fix Rust 1.45.0 CI failure #786

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

ridwanabdillahi
Copy link
Contributor

@ridwanabdillahi ridwanabdillahi commented Aug 16, 2022

The Rust 1.45.0 CI job has started failing due to an update of the serde and serde_derive crates. The latest updates to these crates causes cargo to require the resolver feature which was unstable in the version of cargo shipped in the Rust 1.45.0 toolchain.

This feature has since been stabilized in the version of cargo shipped with the Rust 1.51.0 toolchain.

This change updates the minimum rust-version to Rust 1.51.0 and updates the github actions workflow to test against Rust 1.51.0 instead of Rust 1.45.0

Linked issue: #785

….45 CI pipeline due to an update of dependencies that now require the cargo `resolver` feature to be stablized.
@codecov-commenter
Copy link

Codecov Report

Merging #786 (6353d50) into master (a72f83d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #786   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          22       22           
  Lines        3894     3894           
=======================================
  Hits         3319     3319           
  Misses        575      575           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@valenting valenting merged commit d6b4cda into servo:master Aug 17, 2022
@valenting
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants