Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add description method to ParseError #802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add description method to ParseError #802

wants to merge 1 commit into from

Conversation

samuelcolvin
Copy link

fix #801

@samuelcolvin
Copy link
Author

See pydantic/pydantic-core#324 and in particular here where I'd like to use the static str, rather than a String.

@samuelcolvin
Copy link
Author

Hi, the linting failures are not related to this PR, would you like me to fix them here?

@valenting
Copy link
Collaborator

Could you rebase your patch so we can pick up the latest changes?

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #839) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ParseError.description() -> &'static str method like already implemented on SyntaxViolation
3 participants
@samuelcolvin @valenting @bors-servo