Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Host::IPv4/IPv6 with single variant taking IpAddr #818

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace Host::IPv4/IPv6 with single variant taking IpAddr #818

wants to merge 4 commits into from

Conversation

Hyxogen
Copy link

@Hyxogen Hyxogen commented Feb 28, 2023

This change will make it easier to use the Host enum in a more generic way with the standard library.

@valenting
Copy link
Collaborator

This would constitute a breaking change.
Could you outline how this change makes it easier to use Host with the standard library?
Some examples or links to other crates that are having this issue would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hyxogen @valenting