-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: building a browser using Servo as a web engine #171
Conversation
I’ll review this next week, after the monthly update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial high-level feedback :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I update a few wording, but feel free to update them if that's not enough.
- fixed heading levels - updated triage link to point to next meeting - added articles - fixed number and tense agreement - more terse and idiomatic word choice - more consistent use of terminology - biweekly → every two weeks <https://en.wiktionary.org/w/index.php?title=biweekly&oldid=81072047#Usage_notes> - removed “and listen”, since we don’t want to discourage active participation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve done some copyediting:
- fixed heading levels
- updated triage link to point to next meeting
- added articles
- fixed number and tense agreement
- more terse and idiomatic word choice
- more consistent use of terminology
- biweekly → every two weeks
- removed “and listen”, since we don’t want to discourage active participation
- rewrote the intro to have a clearer flow from embedding to browsers
You can see what I changed more easily with git diff --word-diff=color b1ebb4c21e96ee912d51527361173dcc40627e01
:)
I’ve also added some <!-- comments --> with some questions I had while reading your post. Let me know what you think!
- Grammar fix on practical requirements - Add an example of why we need to improve IPC mechanism Signed-off-by: Ngo Iok Ui (Wu Yu Wei) <yuweiwu@pm.me>
ffmpeg -i verso-crt-demo.mov -vcodec libwebp -filter:v fps=fps=30 -lossless 0 -compression_level 6 -q:v 80 -loop 0 -preset picture -an -vsync 0 -s 580:190 verso-crt-demo.webp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this blog post, it's really nice to show other uses cases for Servo.
I've left a few comments, mostly minors, so feel free to ignore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this! I’ve pushed a couple more commits to clarify the new wording and bump the date to today, but otherwise it looks good.
@delan Can I add a blog post about the progress of the browser research that NLNet sponsors?
This will be the final task for https://nlnet.nl/project/Servo-Multibrowsing/
The gif is a bit large. If it's not desired, I can change to iframe with this source: https://github.com/versotile-org/demo-page/blob/main/crt.html