libservo: update stylo preferences in multiprocess mode. #34661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When servo is run in multiprocess mode, the content process receives the preferences via IPC from the main process. However, currently these preferences are only used to update Servo's own preferences by explictly calling Preference::set_all(). This doesn't ensure that stylo's copy of preferences is also updated. This change replaces the call to `Preference::set_all()` with call to `add_user_prefs` which does ensure both Servo's and Stylos' preferences are updated. Fixes servo#34660. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
|
🔨 Triggering try run (#12367542868) for Linux WPT perf, MacOS, Windows, Android, OpenHarmony, Lint |
Bencher Report
|
Test results for linux-wpt-layout-2020 from try job (#12367542868): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (13)
|
|
✨ Try run (#12367542868) succeeded. |
mrobinson
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When servo is run in multiprocess mode, the content process receives the preferences via IPC from the main process. However, currently these preferences are only used to update Servo's own preferences by explictly calling
Preferences::set_all(). This doesn't ensure that stylo's copy of preferences is also updated.This change replaces the call to
Preference::set_all()with call toadd_user_prefswhich does ensure both Servo's and Stylos' preferences are updated.Fixes #34660.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors