layout: Support `stretch` cross size for flex base size #35663

Loirooriol · 2025-02-25T22:25:51Z

The computation of the flex base size may involve transferring a definite cross size into the main axis through the aspect ratio. We were only considering numeric sizes as definite, but stretch can also be definite.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes are part of Support intrinsic sizing keywords: min-content, max-content, fit-content, and fit-content() #32853
There are tests for these changes

github-actions · 2025-02-25T22:26:07Z

🔨 Triggering try run (#13532175549) for Linux (WPT)

servo-wpt-sync · 2025-02-25T22:28:36Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#50948) with upstreamable changes.

github-actions · 2025-02-25T22:54:54Z

Test results for linux-wpt-layout-2020 from try job (#13532175549):

Flaky unexpected result (25)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
FAIL [expected PASS] /_mozilla/css/text_transform_none_a.html
FAIL [expected PASS] /css/css-fonts/font-stretch-06.html
OK /css/css-grid/alignment/grid-content-alignment-with-abspos-001.html (#34339)
- PASS [expected FAIL] subtest: .grid 1
FAIL [expected PASS] /css/css-text/shaping/shaping-009.html

OK /css/css-values/cap-invalidation.html (#32757)

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

uncaught exception: Error: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - name is missing
- PASS [expected FAIL] subtest: Single value - empty name exists
OK /encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-hangul.html?1001-2000
- FAIL [expected PASS] subtest: hangul U+AFE8 꿨 %26%2345032%3B
```
assert_equals: expected "%26%2345032%3B" but got "%26%2344232%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFE9 꿩 %26%2345033%3B
```
assert_equals: expected "%26%2345033%3B" but got "%26%2344233%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFEA 꿪 %26%2345034%3B
```
assert_equals: expected "%26%2345034%3B" but got "%26%2344234%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFEB 꿫 %26%2345035%3B
```
assert_equals: expected "%26%2345035%3B" but got "%26%2344235%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFEC 꿬 %26%2345036%3B
```
assert_equals: expected "%26%2345036%3B" but got "%26%2344236%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFED 꿭 %26%2345037%3B
```
assert_equals: expected "%26%2345037%3B" but got "%26%2344237%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFEE 꿮 %26%2345038%3B
```
assert_equals: expected "%26%2345038%3B" but got "%26%2344238%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFEF 꿯 %26%2345039%3B
```
assert_equals: expected "%26%2345039%3B" but got "%26%2344239%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFF0 꿰 %26%2345040%3B
```
assert_equals: expected "%26%2345040%3B" but got "%26%2344240%3B"
```
- FAIL [expected PASS] subtest: hangul U+AFF1 꿱 %26%2345041%3B
```
assert_equals: expected "%26%2345041%3B" but got "%26%2344241%3B"
```
- And 190 more unexpected results...
CRASH [expected OK] /fetch/api/response/response-stream-with-broken-then.any.html (#35419)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.tentative.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 3, 3] length 3
```
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html (#34117)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
TIMEOUT [expected OK] /html/semantics/document-metadata/the-base-element/base_target_does_not_affect_location_assignment.html (#32615)
- TIMEOUT [expected PASS] subtest: base_target_does_not_affect_location_assignment
```
Test timed out
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace-set-src.html (#32697)
- PASS [expected FAIL] subtest: Navigating iframe loading='lazy' and then setting src: location.replace
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
OK [expected TIMEOUT] /performance-timeline/navigation-id-detached-frame.tentative.html (#34773)
- PASS [expected TIMEOUT] subtest: The navigation_id getter does not crash a window of detached frame
OK /resize-observer/change-layout-in-error.html (#32629)
- PASS [expected FAIL] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.
CRASH [expected PASS] /shadow-dom/focus/focus-pseudo-on-shadow-host-3.html
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)

Stable unexpected results that are known to be intermittent (10)

FAIL [expected PASS] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
OK [expected CRASH] /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '350 399' over '351 398'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '501 550' over '502 560'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '399' should prefer '400' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique -40deg -30deg' over 'italic'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique -40deg -30deg' over 'italic'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique 40deg 50deg' over 'italic'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- FAIL [expected PASS] subtest: Duplicate name lookup order
```
assert_equals: subtree first expected "ChildA" but got "SiblingA"
```
FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- FAIL [expected PASS] subtest: Verifies that location navigations take precedence when following form submissions.
```
assert_equals: expected "/html/semantics/forms/form-submission-0/resources/location.html" but got "/html/semantics/forms/form-submission-0/resources/form.html"
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```

github-actions · 2025-02-25T22:55:06Z

✨ Try run (#13532175549) succeeded.

The computation of the flex base size may involve transferring a definite cross size into the main axis through the aspect ratio. We were only considering numeric sizes as definite, but `stretch` can also be definite. Signed-off-by: Oriol Brufau <obrufau@igalia.com>

servo-wpt-sync · 2025-02-26T17:23:09Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#50948).

Loirooriol added A-layout/flex A-layout/2020 T-linux-wpt labels Feb 25, 2025

Loirooriol requested review from mrobinson and nicoburns as code owners February 25, 2025 22:25

github-actions bot removed the T-linux-wpt label Feb 25, 2025

servo-wpt-sync mentioned this pull request Feb 25, 2025

layout: Support stretch cross size for flex base size web-platform-tests/wpt#50948

Merged

Loirooriol force-pushed the flexbox-flex-base-size-stretch branch from c546618 to 0dc4231 Compare February 26, 2025 17:19

mrobinson approved these changes Feb 26, 2025

View reviewed changes

Loirooriol added this pull request to the merge queue Feb 26, 2025

Merged via the queue into servo:main with commit 03e953e Feb 26, 2025
22 checks passed

Loirooriol deleted the flexbox-flex-base-size-stretch branch February 26, 2025 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

layout: Support `stretch` cross size for flex base size #35663

layout: Support `stretch` cross size for flex base size #35663

Loirooriol commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

servo-wpt-sync commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

servo-wpt-sync commented Feb 26, 2025

layout: Support stretch cross size for flex base size #35663

layout: Support stretch cross size for flex base size #35663

Conversation

Loirooriol commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

servo-wpt-sync commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

servo-wpt-sync commented Feb 26, 2025

layout: Support `stretch` cross size for flex base size #35663

layout: Support `stretch` cross size for flex base size #35663