Skip to content

Commit aecdede

Browse files
author
bors-servo
authored
Auto merge of #167 - servo:rustup, r=nox
Drop flags are gone, long live MIR! <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/167) <!-- Reviewable:end -->
2 parents 9abce78 + 5b5204e commit aecdede

File tree

3 files changed

+2
-16
lines changed

3 files changed

+2
-16
lines changed

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
name = "string_cache"
4-
version = "0.2.24"
4+
version = "0.2.25"
55
authors = [ "The Servo Project Developers" ]
66
description = "A string interning library for Rust, developed as part of the Servo project."
77
license = "MIT / Apache-2.0"

src/atom/mod.rs

-13
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ impl StringCache {
169169

170170
// NOTE: Deriving Eq here implies that a given string must always
171171
// be interned the same way.
172-
#[cfg_attr(feature = "unstable", unsafe_no_drop_flag)] // See tests::atom_drop_is_idempotent
173172
#[derive(Eq, Hash, PartialEq)]
174173
pub struct Atom {
175174
/// This field is public so that the `atom!()` macro can use it.
@@ -771,18 +770,6 @@ mod tests {
771770
let _: &str = atom.as_ref();
772771
}
773772

774-
/// Atom uses #[unsafe_no_drop_flag] to stay small, so drop() may be called more than once.
775-
/// In calls after the first one, the atom will be filled with a POST_DROP value.
776-
/// drop() must be a no-op in this case.
777-
#[cfg(feature = "unstable")]
778-
#[test]
779-
fn atom_drop_is_idempotent() {
780-
use super::from_packed_dynamic;
781-
unsafe {
782-
assert_eq!(from_packed_dynamic(mem::POST_DROP_U64), None);
783-
}
784-
}
785-
786773
#[test]
787774
fn string_cache_entry_alignment_is_sufficient() {
788775
assert!(mem::align_of::<StringCacheEntry>() >= ENTRY_ALIGNMENT);

src/lib.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
#![crate_type = "rlib"]
1212

1313
#![cfg_attr(test, deny(warnings))]
14-
#![cfg_attr(all(test, feature = "unstable"), feature(test, filling_drop))]
15-
#![cfg_attr(feature = "unstable", feature(unsafe_no_drop_flag))]
14+
#![cfg_attr(all(test, feature = "unstable"), feature(test))]
1615

1716
#[cfg(all(test, feature = "unstable"))] extern crate test;
1817
#[cfg(feature = "log-events")] extern crate rustc_serialize;

0 commit comments

Comments
 (0)