Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop flags are dead, long live MIR! #167

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Drop flags are dead, long live MIR! #167

merged 1 commit into from
Aug 26, 2016

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 26, 2016 •
edited by larsbergstrom
Loading

This change is Reviewable

@nox
Copy link
Contributor

nox commented Aug 26, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 5b5204e has been approved by nox

bors-servo pushed a commit that referenced this pull request Aug 26, 2016
Auto merge of #167 - servo:rustup, r=nox
aecdede 
Drop flags are gone, long live MIR!

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/167)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 5b5204e with merge aecdede...

@bors-servo
Copy link
Contributor

💔 Test failed - status-travis

@SimonSapin SimonSapin changed the title Drop flags are gone, long live MIR! Drop flags are dead, long live MIR! Aug 26, 2016
@SimonSapin
Copy link
Member Author

Fixed up assert_sizes test to support both compiler with and without inline drop flags.

@nox
Copy link
Contributor

nox commented Aug 26, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 4c0ee07 has been approved by nox

@bors-servo
Copy link
Contributor

⌛ Testing commit 4c0ee07 with merge 7031f90...

bors-servo pushed a commit that referenced this pull request Aug 26, 2016
Auto merge of #167 - servo:rustup, r=nox
7031f90 
Drop flags are dead, long live MIR!

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/167)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 4c0ee07 into master Aug 26, 2016
@bors-servo bors-servo mentioned this pull request Aug 26, 2016
Closed
@SimonSapin SimonSapin deleted the rustup branch August 26, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonSapin @nox @bors-servo