New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream comment has been addressed #123

Closed

frewsxcv opened this issue Nov 19, 2015 · 1 comment

Contributor

frewsxcv commented Nov 19, 2015

string-cache/plugin/src/atom/mod.rs

Line 30 in ce7133c

// FIXME: libsyntax should provide this (rust-lang/rust#17637)

rust-lang/rust#17637

Member

SimonSapin commented Nov 19, 2015

This would become irrelevant if we go through with #124.

SimonSapin mentioned this issue

Merge into a single crate. Use macros even on unstable. #125

Merged

bors-servo pushed a commit that referenced this issue


          Auto merge of #125 - servo:no-plugin, r=asajeffrey

76d6428

Merge into a single crate. Use macros even on unstable.

Breaking changes:

* `ns!("")` should be written `ns!()`
* Other `ns!(…)` macros should be lowercase, unquoted.

Fixes #124
Closes #123

r? @asajeffrey

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/125)
<!-- Reviewable:end -->

bors-servo closed this as completed in #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment