Make tests pass on a 32-bit system. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testable on 64-bit Linux with: ``` rustup target add i686-unknown-linux-gnu cargo test --target i686-unknown-linux-gnu ``` (or similarly on anther 64-bit platforms), assuming a linker and libc for this target are available on the system. Leaving #162 open to add CI for this. (Unfortunately Travis doesn’t use rustup out of the box.)
|
@bors-servo r+ |
|
📌 Commit 40d8629 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 25, 2016
Make tests pass on a 32-bit system. Testable on 64-bit Linux with: ``` rustup target add i686-unknown-linux-gnu cargo test --target i686-unknown-linux-gnu ``` (or similarly on anther 64-bit platforms), assuming a linker and libc for this target are available on the system. Leaving #162 open to add CI for this. (Unfortunately Travis doesn’t use rustup out of the box.) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/176) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testable on 64-bit Linux with:
(or similarly on anther 64-bit platforms), assuming a linker and libc for this target are available on the system.
Leaving #162 open to add CI for this. (Unfortunately Travis doesn’t use rustup out of the box.)
This change is