Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fxhash with rustc-hash #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paolobarbolini
Copy link

The fxhash crate hasn't been maintained in the last 6 years. This migrates to rustc-hash, which is much more popular crate developed by the Rust project and used by the Rust compiler.

@mrobinson
Copy link
Member

mrobinson commented Mar 23, 2025

@paolobarbolini Thanks for the contribution.

This crate is a downstream version of Gecko's style. We ask that non-Servo-specific changes be submitted upstream: https://searchfox.org/mozilla-central/source/servo/components.

@nicoburns
Copy link
Collaborator

There's a guide to submitting patches to Gecko here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

However, I would note that "fxhash" stands for Firefox Hash so I'm not sure how open they would be to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants