-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servo: Add support for parsing :is()
and :where()
#80
servo: Add support for parsing :is()
and :where()
#80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We've done this in Blitz and it seems to work. My one reservation would be that I believe that "nth-child" and "has" require extra invalidation logic that is not handled by Stylo and needs to be handled externally.
(I am keen to document how that works, probably as an example in the Stylo repo, but I haven't worked it out myself yet)
Yeah have you confirmed that |
It's functional, but there's still work to do with invalidation, as @nicoburns mentioned above. |
Should this be closed like servo/servo#33543 ? |
I think this should be scoped down. I believe |
c2f7754
to
3e44b02
Compare
:is()
, :has()
, :where()
, and nesting selectors:is()
and :where()
Stylo supports these and they just need to be turned on. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
3e44b02
to
b2e128f
Compare
@nicoburns , is there a tracking issue for the integration work required for the I'm also wondering whether this issue is the same or distinct from the work required to support the Apologies if I've asked anything ignorant here, I'm not super familiar with this project yet |
Stylo supports these and they just need to be turned on. This change
also ensures that forgiving selector mode is turned off when parsing
selectors for the
@supports
rule.Signed-off-by: Martin Robinson mrobinson@igalia.com