Fix some issues with the CI #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't as important any longer, now that Servo is using Rust stable. Additionally, surfman no longer compiles with version of Rust nightly that we were previously using. The motivation here is to fix the CI and to move toward having a MSRV.
mrobinson
force-pushed
the
compile-with-latest-rust-nightly
branch
from
fd498b2 to
a7bea55
Compare
mukilan
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test surfman with rust nightly. Additionally, surfman no longer
compiles with the old version of Rust nightly that we were previously
using. Only test with stable rust.
if there is a failure on CI.