Fix some simple clippy lints #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GlApi` is Copy and a simple enum on all platforms, so point in dropping it explicitly.
mrobinson
approved these changes
Apr 21, 2024
mrobinson
requested changes
Apr 21, 2024
auto-merge was automatically disabled
April 21, 2024 14:53
Head branch was pushed to by a user without write access
I agree - but I think the examples need to be fixed first (they are not compiling, and cause clippy to fail). Locally, I just ignored the issue by deleted the examples folder. |
mrobinson
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each lint was fixed in an individual commit, for easier review.
After this PR clippy is warning free when run on surfman, examples are excluded and the following lints are allowed: