Run on stable Rust #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids breaking dependent crates when e.g. Rust deprecates something.
Only use `unsafe_no_drop_flag` and `NonZero` when the `unstable` Cargo feature is enabled. Without the feature, on 64 bit platforms: * `Tendril<_>` is 17 bytes instead of 16. (It has a drop flag.) * `Option<Tendril<_>>` is 18 bytes instead of 16. (It has a drop flag and an explicit tag.)
|
Blocked on reem/rust-debug-unreachable#2 being on crates.io |
SimonSapin
added a commit
to SimonSapin/travis-doc-upload
that referenced
this pull request
Jul 19, 2015
This will avoid duplicate uploads when Travis-CI runs with multiple Rust version like in servo/tendril#14
|
Reviewed 3 of 7 files at r1, 6 of 6 files at r2. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
@bors-servo r+ |
|
📌 Commit b4d2c2f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 24, 2015
Run on stable Rust Without the `unstable` Cargo feature, on 64 bit platforms: * `Tendril<_>` is 17 bytes instead of 16. (It has a drop flag.) * `Option<Tendril<_>>` is 18 bytes instead of 16. (It has a drop flag and an explicit tag.) r? @Manishearth Needed for servo/html5ever#53 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/tendril/14) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
unstableCargo feature, on 64 bit platforms:Tendril<_>is 17 bytes instead of 16. (It has a drop flag.)Option<Tendril<_>>is 18 bytes instead of 16. (It has a drop flag and an explicit tag.)r? @Manishearth
Needed for servo/html5ever#53