Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests should check orderings *and* levels #88

Closed
Manishearth opened this issue Dec 19, 2022 · 0 comments · Fixed by #105
Closed

Conformance tests should check orderings *and* levels #88

Manishearth opened this issue Dec 19, 2022 · 0 comments · Fixed by #105
Assignees
@Manishearth

Comments

@Manishearth
Copy link
Member

Manishearth commented Dec 19, 2022 •
edited
Loading

BidiConformanceTests.txt contains an expected list of levels and an expected ordering, we only test the former.

Expected ordering depends on expected levels so as long as our visual_runs algorithm is correct this ought to still pass, but we should still test it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run reordering conformance tests, more docs for reordering, fix bug Manishearth/unicode-bidi
1 participant
@Manishearth