Run reordering conformance tests, more docs for reordering, fix bug #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
reorder-conformance
branch
from
13d8f97 to
46d3c73
Compare
mbrubeck
approved these changes
Mar 21, 2023
| @@ -637,20 +682,19 @@ impl<'text> BidiInfo<'text> { | |||
| // Look for the start of a sequence of consecutive runs of max_level or higher. | |||
| let mut seq_start = 0; | |||
| while seq_start < run_count { | |||
| if self.levels[runs[seq_start].start] < max_level { | |||
| if levels[runs[seq_start].start] < max_level { | |||
There was a problem hiding this comment.
We should also update the comment above the loop, which says that this loop uses the original levels instead of the ones for reordering.
There was a problem hiding this comment.
Yeah, technically it's still not "checking reordering" because in this case that vector doesn't exist here (the reorderings are managed by the runs vector), but ultimately it is checking the "right" levels here unlike the other method which happens to work due to some invariants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
We now run the reordering part of the conformance tests. Good news: we already passed them all for
reorder_visual()!. There was a small bug when it came tovisual_runs()which took a bit of sleuthing but was easy to fix.