Skip to content
This repository was archived by the owner on Feb 16, 2025. It is now read-only.

The headless test device shouldn't ignore the sync object #14

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

asajeffrey
Copy link
Member

Apparently you get GL errors if you create a sync object but never fence on it.

@asajeffrey
Copy link
Member Author

r? @Manishearth

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0574860 has been approved by Manishearth

@bors-servo
Copy link
Contributor

⌛ Testing commit 0574860 with merge 3eede21...

bors-servo pushed a commit that referenced this pull request Jul 11, 2019
The headless test device shouldn't ignore the sync object

Apparently you get GL errors if you create a sync object but never fence on it.
@bors-servo
Copy link
Contributor

💔 Test failed - checks-travis

@Manishearth
Copy link
Member

Ooh, build failure on nightly with serde_derive.

@Manishearth
Copy link
Member

rust-lang/rust#62562

@Manishearth Manishearth merged commit 952a666 into servo:master Jul 11, 2019
@Manishearth
Copy link
Member

It's going to be another nightly cycle before that's fixed, but we don't use cutting edge nightly anyway

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants