feat: serve css experiment #815
Conversation
| @@ -11,8 +11,9 @@ | |||
| "format:ci-cd": "prettier --check '**/*.{ts,css,json,md}'", | |||
| "lint": "eslint", | |||
| "test": "vitest --pool=forks", | |||
| "test:snapshots": "TEST_SNAPSHOTS=true vitest --pool=forks", | |||
| "test:update-snapshots": "TEST_SNAPSHOTS=true vitest --pool=forks -u", | |||
| "serve-css": "serve src/styles -l 48484", | |||
There was a problem hiding this comment.
I just picked this port number randomly because I kept blocking previous ports by not closing serve properly (using concurrently fixes this)
| @@ -32,7 +32,7 @@ export async function snapshotResponse( | |||
| // CSS hack - we are not serving the CSS on this PR though | |||
| const responseBody = responseText.replace( | |||
| "/css/tailwind.css", | |||
| "http://auth2.sesamy.dev/css/tailwind.css", | |||
| "http://172.17.0.1:48484/tailwind.css", | |||
There was a problem hiding this comment.
this is the issue!
I don't see any errors from serve that we cannot do this on a github runner, but I don't know what should be here
Running locally I can just put http://localhost:48484/tailwind.css and it works 🤔
Whether it's a restriction on the github runners... I'm not sure
There was a problem hiding this comment.
see the commit history f0b45e4
Indeed that is what I tried first 👍
|
@markusahlstrand I spent 45 minutes on this. I think it's in the right direction but I don't want to waste all day 🥲 |
|
I'm not sure I follow completely, but why don't we serve the css via hono? |
By serve do you mean inline the whole spreadsheet? |
Bah this works locally for me running docker on my machine, but it blows up on the github runners 🤔