Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes related to release and deploy #108

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

PradeepWeb77
Copy link
Collaborator

Make changes related to release and deploy

@julianidiart
Copy link
Contributor

For semantic release to work, you must follow the specifications for commit messages, check here: https://www.conventionalcommits.org/en/v1.0.0/#summary. Otherwise, semantic release will not create a new tag.

@julianidiart
Copy link
Contributor

julianidiart commented Apr 26, 2024

@PradeepWeb77, check this comment:

For semantic release to work, you must follow the specifications for commit messages, check here: https://www.conventionalcommits.org/en/v1.0.0/#summary. Otherwise, semantic release will not create a new tag.

You're still committing with a non-conventional commit message, which will result in the semantic release not being triggered once we merge with master branch.

Another thing I found with the last commit: If we rearrange the order of the steps, and get the last tag from GitHub before modifying the WordPress files, we don't need to look for the tag in version.sh and changelog.sh, we can pass it as an argument of the script and we avoid the same call 3 times.

Lastly, make sure you merge the latest changes from master, since there are some changes there, and there's a conflict with one file (package.json, it's related to the manual release of a new version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants