fix: handle if meta is undefined #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusahlstrand
commented
Nov 4, 2024
| @@ -11,14 +11,6 @@ import { __ } from "@wordpress/i18n"; | |||
| import { useEffect, useState, useMemo } from "@wordpress/element"; | |||
| import { store as coreStore } from "@wordpress/core-data"; | |||
|
|
|||
| function* getPaymentOptions(enableTiers) { | |||
There was a problem hiding this comment.
This code was not used.
markusahlstrand
commented
Nov 4, 2024
| @@ -50,8 +42,8 @@ const SesamyPostEditor = () => { | |||
| const meta = useSelect((select) => | |||
| select("core/editor").getEditedPostAttribute("meta") | |||
| ); | |||
| const tagMetaValue = meta["_sesamy_tags"].split("|"); | |||
| //const sesamyTiersTaxonomy = wp.data.select('core').getEntityRecords('taxonomy', 'sesamy_passes'); | |||
| const tagMetaValue = meta["_sesamy_tags"]?.split("|"); | |||
There was a problem hiding this comment.
Default to null if not defined.
markusahlstrand
commented
Nov 4, 2024
| @@ -98,11 +90,11 @@ const SesamyPostEditor = () => { | |||
| }; | |||
|
|
|||
| const setTag = (tag, included) => { | |||
| var tag_array = tagMetaValue ? tagMetaValue : []; | |||
| let tag_array = tagMetaValue ? tagMetaValue : []; | |||
There was a problem hiding this comment.
Just a bit cleaning aways some var's.
markusahlstrand
commented
Nov 4, 2024
| } | ||
| } | ||
| ) | ||
| if (!data.sesamyItemSrc) { |
There was a problem hiding this comment.
Prettier fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If meta['sesamy-tags'] is undefined this would crash.