Improved windows installer and OS min version enforcement #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Windows installer by adding OS version enforcement and enhances the installation experience. The changes ensure users have Windows 10 or later before allowing installation and provide additional installer customization options.
Key changes:
- Added minimum Windows 10 requirement with version checking in the installer
- Enhanced installer UI with custom sidebar and startup options
- Added rc-slider dependency and macOS minimum system version requirement
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Added rc-slider dependency, macOS minimum system version, and Windows installer customization options |
| build/installer.nsh | New NSIS script implementing Windows version checking and custom installer behaviors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…n and enforce min version
Aerilym
force-pushed
the
feat/installer_improvements_and_min_system_version
branch
from
8e1a812 to
552850e
Compare
Bilb
requested changes
Aug 27, 2025
Bilb
approved these changes
Aug 27, 2025
|
just need to make sure it still works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept all the boilerplate code for what you can use in an electron-builder custom nsh script, but the additional code can be removed.