Skip to content

fix: PLAYWRIGHT_WORKER_COUNT should be PLAYWRIGHT_WORKERS_COUNT #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: PLAYWRIGHT_WORKER_COUNT should be PLAYWRIGHT_WORKERS_COUNT #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324ab72
fix: PLAYWRIGHT_WORKERS_COUNT should be PLAYWRIGHT_WORKER_COUNT
yougotwill Jan 14, 2025
5e899f0
fix: we want to use the plural WORKERS
yougotwill Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ SESSION_DESKTOP_ROOT="<path to session desktop root>"
PLAYWRIGHT_CUSTOM_REPORTER=1
PLAYWRIGHT_REPEAT_COUNT=0
PLAYWRIGHT_RETRIES_COUNT=0
PLAYWRIGHT_WORKER_COUNT=1
PLAYWRIGHT_WORKERS_COUNT=1
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Create your own config from the `.env.sample` and edit the values to match your
- *type*: number
- *default*: 0
- *description*: the number of retries each test. i.e. if a test **failed** on attempt x, and our current attempt is `< PLAYWRIGHT_RETRIES_COUNT` the test will be scheduled to be run again. This can be used to debug flaky tests
- `PLAYWRIGHT_WORKER_COUNT`
- `PLAYWRIGHT_WORKERS_COUNT`
- *type*: number
- *default*: 1
- *description*: the number of workers to start in parallel. The more, the faster the test suite is going to run, but if you hit your CPU limit they'll start to be unnecessarily flaky. Should be fine with a value between 10-20 depending on the machine.
Expand Down