Adds in disappearing messages test turning off #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burtonemily
commented
Dec 17, 2024
Comment on lines
+320
to
+358
| // Each window has two control messages: You turned off and other user turned off (because we're following settings) | ||
| await Promise.all([ | ||
| waitForTestIdWithText( | ||
| aliceWindow1, | ||
| 'disappear-control-message', | ||
| englishStrippedStr('disappearingMessagesTurnedOffYou').toString(), | ||
| ), | ||
| waitForTestIdWithText( | ||
| aliceWindow1, | ||
| 'disappear-control-message', | ||
| englishStrippedStr('disappearingMessagesTurnedOff') | ||
| .withArgs({ name: bob.userName }) | ||
| .toString(), | ||
| ), | ||
| waitForTestIdWithText( | ||
| aliceWindow2, | ||
| 'disappear-control-message', | ||
| englishStrippedStr('disappearingMessagesTurnedOffYou').toString(), | ||
| ), | ||
| waitForTestIdWithText( | ||
| aliceWindow2, | ||
| 'disappear-control-message', | ||
| englishStrippedStr('disappearingMessagesTurnedOff') | ||
| .withArgs({ name: bob.userName }) | ||
| .toString(), | ||
| ), | ||
| waitForTestIdWithText( | ||
| bobWindow1, | ||
| 'disappear-control-message', | ||
| englishStrippedStr('disappearingMessagesTurnedOff') | ||
| .withArgs({ name: alice.userName }) | ||
| .toString(), | ||
| ), | ||
| waitForTestIdWithText( | ||
| bobWindow1, | ||
| 'disappear-control-message', | ||
| englishStrippedStr('disappearingMessagesTurnedOffYou').toString(), | ||
| ), | ||
| ]); |
There was a problem hiding this comment.
I'm wanting to create a function that separates out the control message checks but thought I would do it in a different PR. There are alot of control messages and its kinda clogging up the test.
…ion and hide recovery password
Bilb
approved these changes
Dec 17, 2024
Bilb
pushed a commit
that referenced
this pull request
Jan 24, 2025
fix: fix the non-groups test for the groups changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And delete contact test