Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loading notifications animation #64

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ A list of "things" to improve
- [ ] improve test coverage
- [ ] make filters a dropdown overlay
- [ ] theme: restore ability to toggle theme (DARK and System)
- [ ] animate refresh icon
- [ ] badge counts for each filter group
- [ ] fix mark as read (product and account level) animation and state removal

## Later
- [ ] advanced feature for Bitbucket "Your Work" queue
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
},
"dependencies": {
"@atlaskit/modal-dialog": "12.16.0",
"@atlaskit/spinner": "16.3.1",
"@discordapp/twemoji": "15.1.0",
"@electron/remote": "2.1.2",
"axios": "1.7.7",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 18 additions & 7 deletions src/components/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { AtlasIcon } from '@atlaskit/logo';
import { Box, Inline, Stack, Text } from '@atlaskit/primitives';
import Tooltip from '@atlaskit/tooltip';

import Spinner from '@atlaskit/spinner';
import Toggle from '@atlaskit/toggle';
import { AppContext } from '../context/App';
import { quitApp } from '../utils/comms';
Expand All @@ -29,6 +30,7 @@ export const Sidebar: FC = () => {
isLoggedIn,
settings,
updateSetting,
status,
} = useContext(AppContext);

const toggleFilters = () => {
Expand Down Expand Up @@ -195,16 +197,25 @@ export const Sidebar: FC = () => {
<Tooltip content="Refresh notifications" position="right">
<IconButton
label="Refresh notifications"
icon={(iconProps) => (
<RefreshIcon
{...iconProps}
size="medium"
primaryColor="white"
/>
)}
icon={(iconProps) =>
status === 'loading' ? (
<Spinner
label="Refresh notifications"
size={'medium'}
appearance="invert"
/>
) : (
<RefreshIcon
{...iconProps}
size="medium"
primaryColor="white"
/>
)
}
appearance="subtle"
shape="circle"
onClick={() => refreshNotifications()}
isDisabled={status === 'loading'}
/>
</Tooltip>

Expand Down
Loading