Fix importing async classes

[clmnin]

Previously we were unable to import AsyncSearch, AsyncMultiSearch, AsyncUpdateByQuery because the import of AsyncMapping was failing.

# elasticsearch_dsl/__init__.py
try:
    from .document import AsyncDocument  # noqa: F401
    from .faceted_search import AsyncFacetedSearch  # noqa: F401
    from .index import AsyncIndex, AsyncIndexTemplate  # noqa: F401
    
    # fails to import AsyncMapping
    from .mapping import AsyncMapping  # noqa: F401
    from .search import AsyncMultiSearch, AsyncSearch  # noqa: F401
    from .update_by_query import AsyncUpdateByQuery  # noqa: F401

resulting failing imports

# this fails
from elasticsearch_dsl import AsyncSearch

# ERROR: AsyncSearch not found in elasticsearch_dsl/__init__.py

After this small fix we can successfully import every class except AsyncMapping (as it is not implemented)

As @sethmlarson wishes to deprecate Mapping (and never implement AsyncMapping) in 7.x and remove it in 8.x so we might as well remove the import for AsyncMapping, but after @sethmlarson approves this change.

[clmnin]

The linting error (isort) are lines of code I hadn't changed.

diff --git a/elasticsearch_dsl/__init__.py b/elasticsearch_dsl/__init__.py
index 26fe8aa..c258341 100644
--- a/elasticsearch_dsl/__init__.py
+++ b/elasticsearch_dsl/__init__.py
@@ -17,64 +17,21 @@
 
 from . import connections
 from .aggs import A
-from .analysis import analyzer, char_filter, normalizer, token_filter, tokenizer
+from .analysis import (analyzer, char_filter, normalizer, token_filter,
+                       tokenizer)
 from .document import Document, InnerDoc, MetaField
-from .exceptions import (
-    ElasticsearchDslException,
-    IllegalOperation,
-    UnknownDslObject,
-    ValidationException,
-)
-from .faceted_search import (
-    DateHistogramFacet,
-    Facet,
-    FacetedResponse,
-    FacetedSearch,
-    HistogramFacet,
-    NestedFacet,
-    RangeFacet,
-    TermsFacet,
-)
-from .field import (
-    Binary,
-    Boolean,
-    Byte,
-    Completion,
-    CustomField,
-    Date,
-    DateRange,
-    DenseVector,
-    Double,
-    DoubleRange,
-    Field,
-    Float,
-    FloatRange,
-    GeoPoint,
-    GeoShape,
-    HalfFloat,
-    Integer,
-    IntegerRange,
-    Ip,
-    IpRange,
-    Join,
-    Keyword,
-    Long,
-    LongRange,
-    Murmur3,
-    Nested,
-    Object,
-    Percolator,
-    RangeField,
-    RankFeature,
-    RankFeatures,
-    ScaledFloat,
-    SearchAsYouType,
-    Short,
-    SparseVector,
-    Text,
-    TokenCount,
-    construct_field,
-)
+from .exceptions import (ElasticsearchDslException, IllegalOperation,
+                         UnknownDslObject, ValidationException)
+from .faceted_search import (DateHistogramFacet, Facet, FacetedResponse,
+                             FacetedSearch, HistogramFacet, NestedFacet,
+                             RangeFacet, TermsFacet)
+from .field import (Binary, Boolean, Byte, Completion, CustomField, Date,
+                    DateRange, DenseVector, Double, DoubleRange, Field, Float,
+                    FloatRange, GeoPoint, GeoShape, HalfFloat, Integer,
+                    IntegerRange, Ip, IpRange, Join, Keyword, Long, LongRange,
+                    Murmur3, Nested, Object, Percolator, RangeField,
+                    RankFeature, RankFeatures, ScaledFloat, SearchAsYouType,
+                    Short, SparseVector, Text, TokenCount, construct_field)
 from .function import SF
 from .index import Index, IndexTemplate
 from .mapping import Mapping

Should I run isort elasticsearch_dsl/__init__.py and push again?

[sethmlarson]

One comment for you, I appreciate you helping me out :)

[sethmlarson]

Since AsyncMapping doesn't exist you can remove this import.

[sethmlarson]

Good catch here, thank you.

[sethmlarson]

I use isort --profile=black in order to make sure that our auto-formatter is also happy with the import structure. The config for it is in setup.cfg.

[clmnin]

One comment for you, I appreciate you helping me out :)

No problem. I wanted to use async elasticsearch_dsl anyway. Thank you for maintaining the package

[sethmlarson]

LGTM, thank you!