fixup! Do not upload tests if skipped/cancelled

sethrj · Sep 18, 2024 · 1468d37 · 1468d37
1 parent d6fe0ec
commit 1468d37
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/.github/workflows/build-docker.yml b/.github/workflows/build-docker.yml
@@ -119,7 +119,8 @@ jobs:
           ./scripts/ci/test-examples.sh
       - name: Upload test results
         uses: actions/upload-artifact@v4
-        if: ${{contains(['success', 'failure'], steps.test.outcome)}}
+        if: ${{steps.test.outcome == 'success'
+               || steps.test.outcome == 'failure')}}
         with:
           name: test-results-${{matrix.image}}-${{env.CMAKE_PRESET}}
           path: "build/test-results.junit.xml"

diff --git a/.github/workflows/build-fast.yml b/.github/workflows/build-fast.yml
@@ -100,11 +100,12 @@ jobs:
           ccache -s
       - name: Upload test results
         uses: actions/upload-artifact@v4
-        if: ${{contains(['success', 'failure'], steps.test.outcome)}}
-           name: test-results-fast-${{matrix.compiler}}-${{matrix.version}}
-           path: "build/test-results.junit.xml"
-           if-no-files-found: error
-           retention-days: 1
+        if: ${{steps.test.outcome == 'success'
+               || steps.test.outcome == 'failure')}}
+          name: test-results-fast-${{matrix.compiler}}-${{matrix.version}}
+          path: "build/test-results.junit.xml"
+          if-no-files-found: error
+          retention-days: 1
   windows:
     defaults:
       run:
@@ -162,10 +163,11 @@ jobs:
           ccache -s
       - name: Upload test results
         uses: actions/upload-artifact@v4
-        if: ${{contains(['success', 'failure'], steps.test.outcome)}}
-           name: test-results-fast-windows
-           path: "build/test-results.junit.xml"
-           if-no-files-found: error
-           retention-days: 1
+        if: ${{steps.test.outcome == 'success'
+               || steps.test.outcome == 'failure')}}
+          name: test-results-fast-windows
+          path: "build/test-results.junit.xml"
+          if-no-files-found: error
+          retention-days: 1
 
 # vim: set nowrap tw=100:
diff --git a/.github/workflows/build-ultralite.yml b/.github/workflows/build-ultralite.yml
@@ -77,7 +77,8 @@ jobs:
           retention-days: 7
       - name: Upload test results
         uses: actions/upload-artifact@v4
-        if: ${{contains(['success', 'failure'], steps.test.outcome)}}
+        if: ${{steps.test.outcome == 'success'
+               || steps.test.outcome == 'failure')}}
           name: test-results-ultralite-ubuntu
           path: "build/test-results.junit.xml"
           if-no-files-found: error
@@ -138,9 +139,9 @@ jobs:
       - name: Upload test results
         uses: actions/upload-artifact@v4
         if: ${{!cancelled()}}
-           name: test-results-ultralite-windows
-           path: "build/test-results.junit.xml"
-           if-no-files-found: error
-           retention-days: 1
+          name: test-results-ultralite-windows
+          path: "build/test-results.junit.xml"
+          if-no-files-found: error
+          retention-days: 1
 
 # vim: set nowrap tw=100: