-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a parsing bug for project-id #33
Conversation
Sentry.io has started to give out project numbers that are bigger than an integer. This patch changes the parsing of the project id to a long, instead of an integer. In addition, the few dependencies that exists are upgraded to the latest version, with a special mention to clj-http-lite. The clj-commons version is used there, as it is maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and the ping on Slack, my GitHub notifications are somewhat unmonitored these days 🙂
Would you mind also updating the changelog? Then I'll try to merge + cut a release asap :)
Sorry that it took a while. Been a bit busy :) |
Any news on getting this merged and released? |
Ping @martinklepsch :) |
@emil0r Thanks for the PR and adjustments & sorry it's been taking so long. I've tried to deploy the new version to Clojars today but am encountering an issue with I know this is a stretch but would you be interested in helping get the deployment tooling for this project running again? I'm pretty open as to what tool to use. I'll also try to not take another 2 weeks to respond again :) |
I can take a look. Looking into boot it seems to be fairly dead. So either lein or the new CLI tools. Do you want to keep boot for the other parts? |
I'm open to remove boot if you feel that would be best / easiest going forward. :) |
Noted. |
Sentry.io has started to give out project numbers that are bigger than an integer. This patch changes the parsing of the project id to a long, instead of an integer.
In addition, the few dependencies that exists are upgraded to the latest version, with a special mention to clj-http-lite. The clj-commons version is used there, as it is maintained.