Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gitlab CI #39

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add support for Gitlab CI #39

merged 1 commit into from
Sep 22, 2022

Conversation

nejec
Copy link
Contributor

@nejec nejec commented Sep 17, 2022

  • adding support for Gitlab CI

README.md Outdated Show resolved Hide resolved
@nejec nejec force-pushed the add-gitlab-ci branch 2 times, most recently from e129eea to 99da352 Compare September 18, 2022 18:07
Comment on lines 20 to 26
var globalKeywords = map[string]bool{
"default": true,
"include": true,
"stages": true,
"variables": true,
"workflow": true,
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more efficient to use a struct instead of a bool, since the empty struct does not allocate

Suggested change
var globalKeywords = map[string]bool{
"default": true,
"include": true,
"stages": true,
"variables": true,
"workflow": true,
}
var globalKeywords = map[string]struct{}{
"default": {},
"include": {},
"stages": {},
"variables": {},
"workflow": {},
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for comments. I have updated the PR and added example testdata/gitlabci.yml.

- adding support for GitLab CI
@sethvargo sethvargo merged commit a87226e into sethvargo:main Sep 22, 2022
@sethvargo
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants