Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component actions are missing @action #105

Closed
basz opened this issue Dec 16, 2021 · 0 comments
Closed

Component actions are missing @action #105

basz opened this issue Dec 16, 2021 · 0 comments
Labels
bug

Comments

@basz
Copy link
Contributor

basz commented Dec 16, 2021

The component actions are missing @action

The close action in particular can't get to the service because of that and errors out

https://github.com/sethwebster/ember-cli-new-version/blob/master/addon/components/new-version-notifier.js#L28
basz added a commit to basz/ember-cli-new-version that referenced this issue Dec 19, 2021
@basz
fix: sethwebster#105 adds action decorator to action methods
e0f63a7
@basz basz mentioned this issue Dec 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knownasilya @basz