Error: The ajax operation was aborted

[bgentry]

If I leave my app running while the connection is unstable (perhaps on a Mac which is regularly sleeping) I see lots of these errors thrown from failed version checks:

Error: The ajax operation was aborted

These bubble up to my app's error handler and get reported to my bug tracking service. That's not ideal as I'd basically need to create a permanent exception for them so I never get notified about it. And also there's no real way for a user of this addon to decide what to catch vs. bubble up.

Maybe there's a higher level question here: which errors, if any, should be swallowed by this version notifier component, and which should bubble up to the app?

One possible interface to help with this would be an onError() closure input similar to the onNewVersion() that I just added. That might be the most flexible in terms of letting the developer choose what to handle.

Anybody have thoughts or other proposals?

[knownasilya]

One possible interface to help with this would be an onError() closure input similar to the onNewVersion() that I just added. That might be the most flexible in terms of letting the developer choose what to handle.

I think that's the right solution.
If not specified we could just log the error, not throw.

[jrjohnson]

I'm great with just logging connection and ajax errors or even swallowing them entirely. I can't envision needing to handle these myself, but if someone desires that then sure onError would be something to add later.

[bgentry]

@jrjohnson sounds great to me, I don’t plan to do anything else with the errors for now but maybe somebody with a more advanced use case could add that if needed.