Log exceptions instead of throwing them #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a network or other issue fetching the VERSION file we should just log it. This prevents ugly user messages or busy logging when users machines go to sleep and stop network traffic.
|
@jrjohnson @knownasilya thanks for merging this! Looking forward to seeing this errors stop after the next release 😄 |
|
@knownasilya can I bug you for a release of this when you have some time? Our app doesn't handle this well and I would love to get it fixed. |
|
v1.3.1 published with this fix |
|
THANKS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a network or other issue fetching the VERSION file we
should just log it. This prevents ugly user messages or busy logging
when users machines go to sleep and stop network traffic.
Fixes #49
Is this all that is needed? Seems too easy.