Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capistrano 2 fixes #109

Merged
merged 4 commits into from
Oct 1, 2015
Merged

Capistrano 2 fixes #109

merged 4 commits into from
Oct 1, 2015

Conversation

wingrunr21
Copy link
Contributor

Hello!

I've got a few minor fixes for capistrano 2 that we encountered when trying to use this in our setup:

  • There was an extraneous pty: false at the end of a run_as command
  • sidekiq_user was not optional like it was in the capistrano 3 task
  • The capistrano 3 task was using puma_user and not sidekiq_user
  • Made sidekiq_user nil by default and added some documentation

Thanks!

@lacco
Copy link

lacco commented Oct 1, 2015

It took a while for me figuring out the exact same issues addressed in this pull request. So please merge it, it's really great work! :)

seuros added a commit that referenced this pull request Oct 1, 2015
@seuros seuros merged commit 1c74293 into seuros:master Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants