Respect both local and global puma_user setting everywhere #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhollinger
force-pushed
the
monit-use-sidekiq_user
branch
from
e611ffb
to
fba43f4
Compare
|
Added additional minor related bugfixes |
seuros
added a commit
that referenced
this pull request
Nov 10, 2015
Respect both local and global puma_user setting everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR is for the monit config to respect the
sidekiq_usersetting (per #121 (comment)).It also normalizes behavior between capistrano-puma's and capistrano-sidekiq's respective
:puma_userand:sidekiq_useroptions. (That is, if seuros/capistrano-puma#139 is accepted.) I imagine many people use both of these gems, and IMHO this subtle difference in their behavior is non-obvious and confusing.