Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get sidekiq_pid value by reading sidekiq_config #140

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

metavida
Copy link

Currently, even if I specify a pidfile value in my sidekiq.yml file, I'm forced to also set a sidekiq_pid value for capistrano-sidekiq. If I don't set a sidekiq_pid value, capistrano-sidekiq actively tells sidekiq to use capistrano-sidekiq's default pidfile location, ignoring my sidekiq.yml value.

This pull has capistrano-sidekiq pick a pidfile in the following order

  1. A user-set sidekiq_pid value (plus any index number)
  2. If a user sets a sidekiq_config value, any pidfile entry for the current sidekiq_env
  3. If a user sets a sidekiq_config value, any global pidfile entry
  4. The default pidfile location (plus any index number)

This Pull request should also address

...because presumably the developer is already smart enough to not put conflicting pidfile paths in their sidekiq config files.
Also update the default value to reflect the change made in seuros#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant