Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fail rolling restart task #196

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

idekeita
Copy link
Contributor

After upgrading from 0.20.0 to 1.0.0, The following errors occured

ArgumentError: wrong number of arguments (given 1, expected 0)
capistrano-sidekiq-1.0.0/lib/capistrano/tasks/sidekiq.rake:134:in `each_process_with_index'
capistrano-sidekiq-1.0.0/lib/capistrano/tasks/sidekiq.rake:94:in `block (4 levels) in <top (required)>'
capistrano-sidekiq-1.0.0/lib/capistrano/tasks/sidekiq.rake:206:in `switch_user'
capistrano-sidekiq-1.0.0/lib/capistrano/tasks/sidekiq.rake:91:in `block (3 levels) in <top (required)>'

The cause is that the argument has changed
https://github.com/seuros/capistrano-sidekiq/blob/v0.20.0/lib/capistrano/tasks/sidekiq.rake#L32
https://github.com/seuros/capistrano-sidekiq/blob/v1.0.0/lib/capistrano/tasks/sidekiq.rake#L132

@seuros seuros merged commit 2534259 into seuros:master Apr 4, 2018
@seuros
Copy link
Owner

seuros commented Apr 4, 2018

Thank you

@idekeita idekeita deleted the fix-fail-rolling-start branch April 4, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants